Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to disallow blocking calls inside allowed blocking calls #329

Merged
merged 4 commits into from
Jan 26, 2023
Merged

Document how to disallow blocking calls inside allowed blocking calls #329

merged 4 commits into from
Jan 26, 2023

Conversation

pderop
Copy link
Contributor

@pderop pderop commented Jan 26, 2023

This PR documents how to disallow blocking calls that are done from allowed blocking calls.
Also committed the junit test proposed by Simon (thanks).

Fixes #187

@pderop pderop changed the title Doc disallow blocking calls inside allowed Document how to disallow blocking calls inside allowed blocking calls Jan 26, 2023
@pderop pderop self-assigned this Jan 26, 2023
@pderop pderop added the type/documentation A documentation update label Jan 26, 2023
@pderop pderop added this to the 1.0.7.RELEASE milestone Jan 26, 2023
@pderop pderop requested a review from a team January 26, 2023 08:46
@pderop pderop mentioned this pull request Jan 26, 2023
Merged
chemicL
chemicL approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@chemicL chemicL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment improvement suggestion, otherwise lookin' good!

@pderop
Copy link
Contributor Author

pderop commented Jan 26, 2023

@chemicL , thanks for the review
@simonbasle , thanks for the proposed junit test

@pderop pderop merged commit e2c3978 into reactor:master Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chemicL chemicL chemicL approved these changes

Assignees

@pderop pderop

Labels
type/documentation A documentation update
Projects
None yet
Milestone
1.0.7.RELEASE
Development

Successfully merging this pull request may close these issues.

Provide example and better document disallowBlockingCallsInside
2 participants
@pderop @chemicL