Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate "Conditional rendering" into Ukrainian #8

Merged
merged 3 commits into from
Feb 15, 2019

Conversation

vldmrkl
Copy link
Member

@vldmrkl vldmrkl commented Feb 13, 2019

This PR contains a Ukrainian translation of Conditional rendering part of the documentation.

content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved

This example renders a different greeting depending on the value of `isLoggedIn` prop.
У цьому прикладі різне вітання відрендериться в залежності від значення пропу `isLoggedIn`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Яка Ваша думка стосовно пропу?
#9 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@klymenkoo, @westanvv should we use властивості as props stands for properties?

Copy link
Member

@oleksii-polovyi oleksii-polovyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start 👍
I think we should change the translation of the prop to властивість.

@oleksii-polovyi
Copy link
Member

@ithompson4 Please review.

@vldmrkl
Copy link
Member Author

vldmrkl commented Feb 15, 2019

@ApolllonDev we're gonna keep props as пропси. This comment explains some downsides of translating it.

@vldmrkl vldmrkl merged commit 82703a9 into reactjs:master Feb 15, 2019
@vldmrkl vldmrkl deleted the uk/conditional-rendering branch June 5, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants