Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Is React Translated Yet? ¡Sí! Sim! はい! blog post #409

Merged
merged 7 commits into from
Oct 7, 2019

Conversation

lyskos97
Copy link
Contributor

@lyskos97 lyskos97 commented Oct 5, 2019

Если ваш пулреквест является исправлением бага, а не переводом, то сперва убедитесь, что проблема относится ТОЛЬКО к https://ru.reactjs.org, а не к https://reactjs.org. Если это не так, то пулреквест следует открыть в родительском репозитории.

@lyskos97
Copy link
Contributor Author

lyskos97 commented Oct 5, 2019

#273

@lyskos97 lyskos97 marked this pull request as ready for review October 5, 2019 20:31
@netlify
Copy link

netlify bot commented Oct 5, 2019

Deploy preview for ru-reactjs ready!

Built with commit dfefa97

https://deploy-preview-409--ru-reactjs.netlify.com

Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Круто, хороший перевод! Некоторые улучшения и исправления.

content/blog/2019-02-23-is-react-translated-yet.md Outdated Show resolved Hide resolved
content/blog/2019-02-23-is-react-translated-yet.md Outdated Show resolved Hide resolved
content/blog/2019-02-23-is-react-translated-yet.md Outdated Show resolved Hide resolved
content/blog/2019-02-23-is-react-translated-yet.md Outdated Show resolved Hide resolved
content/blog/2019-02-23-is-react-translated-yet.md Outdated Show resolved Hide resolved
content/blog/2019-02-23-is-react-translated-yet.md Outdated Show resolved Hide resolved
content/blog/2019-02-23-is-react-translated-yet.md Outdated Show resolved Hide resolved
content/blog/2019-02-23-is-react-translated-yet.md Outdated Show resolved Hide resolved
content/blog/2019-02-23-is-react-translated-yet.md Outdated Show resolved Hide resolved
content/blog/2019-02-23-is-react-translated-yet.md Outdated Show resolved Hide resolved
lyskos97 and others added 2 commits October 6, 2019 10:55
* Fix typos and stylistics

Co-Authored-By: Alexey Pyltsyn <[email protected]>
@lyskos97
Copy link
Contributor Author

lyskos97 commented Oct 6, 2019

@lex111, принял. Спасибо за ревью.
Хотел уточнить: как лучше переводить "contributor"/"contribution" и "maintainer"?

@lyskos97 lyskos97 requested a review from lex111 October 6, 2019 05:30
@lex111
Copy link
Member

lex111 commented Oct 6, 2019

@lyskos97

maintainer -> мейнтейнер
contributor -> участник
contribution -> участие/вклад (в зависимости от контекста)

@lex111 lex111 requested a review from a team October 6, 2019 10:55
Copy link
Collaborator

@gcor gcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Спасибо за перевод. Несколько предложений)

content/blog/2019-02-23-is-react-translated-yet.md Outdated Show resolved Hide resolved
content/blog/2019-02-23-is-react-translated-yet.md Outdated Show resolved Hide resolved
content/blog/2019-02-23-is-react-translated-yet.md Outdated Show resolved Hide resolved
content/blog/2019-02-23-is-react-translated-yet.md Outdated Show resolved Hide resolved
content/blog/2019-02-23-is-react-translated-yet.md Outdated Show resolved Hide resolved
content/blog/2019-02-23-is-react-translated-yet.md Outdated Show resolved Hide resolved
@lyskos97
Copy link
Contributor Author

lyskos97 commented Oct 6, 2019

@gcor, спасибо за ревью!

@lyskos97 lyskos97 requested a review from gcor October 6, 2019 14:38
@lex111
Copy link
Member

lex111 commented Oct 7, 2019

@ntishkevich сливай, если всё ок.

@ntishkevich
Copy link
Collaborator

@lyskos97 Отличная работа! Спасибо за ваш перевод! 💪

@ntishkevich ntishkevich merged commit 4fb0424 into reactjs:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants