Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Перевод главной страницы #19

Merged
merged 5 commits into from
Feb 9, 2019
Merged

Перевод главной страницы #19

merged 5 commits into from
Feb 9, 2019

Conversation

lex111
Copy link
Member

@lex111 lex111 commented Feb 9, 2019

No description provided.

@lex111 lex111 requested a review from gaearon February 9, 2019 12:29
gaearon
gaearon approved these changes Feb 9, 2019
View reviewed changes
Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Немножко хочется попрямее некоторые места, в целом хорошо

content/home/examples/a-component-using-external-plugins.js Outdated Show resolved Hide resolved
content/home/examples/a-simple-component.js Outdated Show resolved Hide resolved
content/home/examples/a-stateful-component.md Outdated Show resolved Hide resolved
content/home/marketing/component-based.md Outdated Show resolved Hide resolved
content/home/marketing/declarative.md Outdated Show resolved Hide resolved
content/home/marketing/declarative.md Show resolved Hide resolved
content/home/marketing/learn-once-write-anywhere.md Outdated Show resolved Hide resolved
content/home/marketing/learn-once-write-anywhere.md Outdated Show resolved Hide resolved
@lex111
Copy link
Member Author

lex111 commented Feb 9, 2019

Круто, спасибо, исправил!

@gaearon
Copy link
Member

gaearon commented Feb 9, 2019

👍

@lex111
Copy link
Member Author

lex111 commented Feb 9, 2019

Можно сливать или подождём ещё дополнительный фидбек?

@gaearon
Copy link
Member

gaearon commented Feb 9, 2019

Да по ходу можно будет поправлять. Давай заливать.

@lex111 lex111 merged commit 1e0e9e6 into master Feb 9, 2019
@lex111 lex111 deleted the home branch February 9, 2019 15:08
@vvscode vvscode mentioned this pull request Mar 19, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lex111 @gaearon @avevlad