Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translate for render-props #163

Merged
merged 67 commits into from
Feb 26, 2019
Merged

Add translate for render-props #163

merged 67 commits into from
Feb 26, 2019

Conversation

Azat74
Copy link
Contributor

@Azat74 Azat74 commented Feb 18, 2019

Перевод статьи Render Props

@Azat74 Azat74 mentioned this pull request Feb 18, 2019
Closed
88 tasks
ntishkevich
ntishkevich reviewed Feb 18, 2019
View reviewed changes
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
lex111
lex111 reviewed Feb 19, 2019
View reviewed changes
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
@lex111 lex111 added the needs review A pull request ready to be reviewed label Feb 19, 2019
ntishkevich and others added 13 commits February 19, 2019 20:46
@ntishkevich @Azat74
Update content/docs/render-props.md
23adbaf 
Co-Authored-By: Azat74 <[email protected]>
@ntishkevich @Azat74
Update content/docs/render-props.md
d7fa528 
Co-Authored-By: Azat74 <[email protected]>
@lex111 @Azat74
Update content/docs/render-props.md
48d6ffc 
Co-Authored-By: Azat74 <[email protected]>
@lex111 @Azat74
Update content/docs/render-props.md
27273c1 
Co-Authored-By: Azat74 <[email protected]>
@ntishkevich @Azat74
Update content/docs/render-props.md
d09f834 
Co-Authored-By: Azat74 <[email protected]>
@ntishkevich @Azat74
Update content/docs/render-props.md
96c47f3 
Co-Authored-By: Azat74 <[email protected]>
@ntishkevich @Azat74
Update content/docs/render-props.md
df0b6c3 
Co-Authored-By: Azat74 <[email protected]>
@ntishkevich @Azat74
Update content/docs/render-props.md
8d08402 
Co-Authored-By: Azat74 <[email protected]>
@lex111 @Azat74
Update content/docs/render-props.md
1ef926c 
Co-Authored-By: Azat74 <[email protected]>
@lex111 @Azat74
Update content/docs/render-props.md
bcd7c7e 
Co-Authored-By: Azat74 <[email protected]>
@ntishkevich @Azat74
Update content/docs/render-props.md
a5b1a60 
Co-Authored-By: Azat74 <[email protected]>
@ntishkevich @Azat74
Update content/docs/render-props.md
01fc123 
Co-Authored-By: Azat74 <[email protected]>
@lex111 @Azat74
Update content/docs/render-props.md
ac5b984 
Co-Authored-By: Azat74 <[email protected]>
@lex111 lex111 mentioned this pull request Feb 19, 2019
Closed
@lex111
Copy link
Member

lex111 commented Feb 22, 2019

@Azat74 вы можете рассмотреть и принять оставшиеся предложенные изменения?

@Azat74
Copy link
Contributor Author

Azat74 commented Feb 24, 2019

@Azat74 вы можете рассмотреть и принять оставшиеся предложенные изменения?

да могу, прошу извинения за задержку

another-guy
another-guy requested changes Feb 26, 2019
View reviewed changes
Copy link
Collaborator

@another-guy another-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Очень тяжело читается. Попробуем упростить.

content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
another-guy and others added 27 commits February 26, 2019 15:49
@another-guy @Azat74
Update content/docs/render-props.md
eec07b9 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
3271d8e 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
e13663d 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
1e846d8 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
58ddf0d 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
8a381fc 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
d3a5157 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
f4edbc2 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
410f7ff 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
fcf07f6 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
f421098 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
461e60b 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
41786fa 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
b6bf5aa 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
5c1823a 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
ae4c3a1 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
1395088 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
d2e68b9 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
01edb3a 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
e723df5 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
c57624f 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
78dbfd5 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
c319b6f 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
fae4be3 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
0972f01 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
80e64fb 
Co-Authored-By: Azat74 <[email protected]>
@another-guy @Azat74
Update content/docs/render-props.md
afaed67 
Co-Authored-By: Azat74 <[email protected]>
@another-guy another-guy merged commit fff12c8 into reactjs:master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntishkevich ntishkevich ntishkevich left review comments

@lex111 lex111 lex111 left review comments

@another-guy another-guy another-guy approved these changes

Assignees
No one assigned
Labels
needs review A pull request ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Azat74 @lex111 @another-guy @ntishkevich