Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong scope for obervables? #1675

Closed
micha149 opened this issue Apr 27, 2016 · 4 comments
Closed

Wrong scope for obervables? #1675

micha149 opened this issue Apr 27, 2016 · 4 comments

Comments

@micha149
Copy link

I was speculating, that this may be an issue of the redux-devtools but after studying the redux code I am not sure anymore. When the devtools chrome extension is activated, my observable transports the devtools state instead of my app state. I could imagine, getState() is called in a wrong scope, or something like this. Did anyone understand where the problem came from?

@gaearon
Copy link
Contributor

gaearon commented Apr 27, 2016

I think we have to override obervable in DevTools now just like we do with getState. Feel free to send a PR!

@micha149
Copy link
Author

Thanks for the hint. I'll have a look on this.

@micha149
Copy link
Author

I implemented the observable in the devtools, which resolves the issue. But I'm not 100% sure if this is an elegant solution… reduxjs/redux-devtools#275

@gaearon
Copy link
Contributor

gaearon commented Apr 27, 2016

Yeah, it's not very cool but does the job. I'll look at this again before cutting 4.0 because there might be a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants