Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new "select" method doesn't work well with the dev tools extension #13

Closed
rubyboy opened this issue May 2, 2016 · 5 comments
Closed

Comments

@rubyboy
Copy link
Contributor

rubyboy commented May 2, 2016

The "select" method doesn't work when the dev tools extension is enabled (https://github.com/zalmoxisus/redux-devtools-extension).

You can see that by adding the following line into the AppComponent of the example app in the project:

      appStore.select((state)=>state).subscribe((state)=>console.log(state));
      // this won't work. Looking at the object outputted above shows why
      appStore.select("counter").subscribe((counter)=>console.log("counter",counter));

You need to have the extension installed (otherwise, it won't enable it)

@micha149
Copy link
Contributor

micha149 commented May 2, 2016

Not a problem of angular2-redux. This is a problem of the dev tools, because it corrupts reduxs observable value. I already made a ticket on redux-devtools and redux. Also fixed the issue but a bit nasty, so @gaearon will look to fix it in redux 4.0.0…

@rubyboy
Copy link
Contributor Author

rubyboy commented May 2, 2016

@micha149 thanks for the explanation and links. Much appreciated!
After starting to use the new "select" function I don't know how I could live without it :)

I'll leave this issue open until it's solved for those using this library and the dev tools.

@gaearon
Copy link

gaearon commented May 9, 2016

Should be solved in DevTools 3.3.0.

@rubyboy
Copy link
Contributor Author

rubyboy commented May 9, 2016

New version of the Chrome extension has been released and this bug has now been solved.
Thanks heaps @gaearon @zalmoxisus @micha149

@rubyboy rubyboy closed this as completed May 9, 2016
@rubyboy
Copy link
Contributor Author

rubyboy commented May 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants