Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalize word "Hook" #6424

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Capitalize word "Hook" #6424

merged 1 commit into from
Nov 10, 2023

Conversation

Huxpro
Copy link
Member

@Huxpro Huxpro commented Nov 9, 2023

Summary of changes:
See #6417.

There is one exception though. The error message
“Rendered fewer hooks than expected” from React is indeed "hooks"
so I kept as-is. Shall we change the error message from React?

Summary of changes:
See <#6417>.

There is one exception though. The error message
“Rendered fewer hooks than expected” from React is indeed "hooks"
so I kept as-is. Shall we change the error message from React?
Copy link

github-actions bot commented Nov 9, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@AhmedBaset
Copy link
Contributor

You're doing a good job BUT keep in mind that this docs is internationalized. Every file you edit will conflict in the weekly rebasing for forks.

that really hurts maintainer. So if that is not necessary please don't do.

thanks

@Huxpro
Copy link
Member Author

Huxpro commented Nov 9, 2023

You're doing a good job BUT keep in mind that this docs is internationalized. Every file you edit will conflict in the weekly rebasing for forks.

that really hurts maintainer. So if that is not necessary please don't do.

thanks

Not gonna lie but I AM maintainer of one of the translation.

In fact, these editions were originated from translators being confused by words "action" being mis-capitalized so it's hard to distinguish if it was the literal word "action" vs. React-specific notion of "React Action" (which should be capitalized).

I can see why this can bring up extra works for translators but hopefully you understand why such enforcement may contribute to better documentation and translation overall.

We will see if a linter can be developed to help stop future commits to the docs mis-capitalize words so bulk edits like this won't happen time to time.

@Huxpro Huxpro requested review from gaearon and lunaleaps November 10, 2023 03:16
@gaearon gaearon merged commit fcd0006 into main Nov 10, 2023
3 checks passed
@gaearon
Copy link
Member

gaearon commented Nov 10, 2023

For consistency I think it's worth doing, but yes, apologies for the churn.

@rickhanlonii rickhanlonii deleted the xuan/captailizeHook branch April 29, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants