-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: apply entering animation synchronously when unmountOnExit or mountOnEnter is enabled #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntOnEnter is enabled
github-actions bot
pushed a commit
that referenced
this pull request
Aug 1, 2022
## [4.4.5](v4.4.4...v4.4.5) (2022-08-01) ### Bug Fixes * apply entering animation synchronously when unmountOnExit or mountOnEnter is enabled ([#847](#847)) ([1043549](1043549))
🎉 This PR is included in version 4.4.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
johnfrench3
pushed a commit
to johnfrench3/transition-group-react
that referenced
this pull request
Nov 2, 2022
## [4.4.5](reactjs/react-transition-group@v4.4.4...v4.4.5) (2022-08-01) ### Bug Fixes * apply entering animation synchronously when unmountOnExit or mountOnEnter is enabled ([#847](reactjs/react-transition-group#847)) ([1043549](reactjs/react-transition-group@1043549))
patrickm68
added a commit
to patrickm68/react-transition-group-developer
that referenced
this pull request
Dec 1, 2022
## [4.4.5](reactjs/react-transition-group@v4.4.4...v4.4.5) (2022-08-01) ### Bug Fixes * apply entering animation synchronously when unmountOnExit or mountOnEnter is enabled ([#847](reactjs/react-transition-group#847)) ([1043549](reactjs/react-transition-group@1043549))
shaikdev2
pushed a commit
to shaikdev2/transition-group-react
that referenced
this pull request
Jun 9, 2023
## [4.4.5](reactjs/react-transition-group@v4.4.4...v4.4.5) (2022-08-01) ### Bug Fixes * apply entering animation synchronously when unmountOnExit or mountOnEnter is enabled ([#847](reactjs/react-transition-group#847)) ([1043549](reactjs/react-transition-group@1043549))
GreenCat1996
added a commit
to GreenCat1996/react-transition-group
that referenced
this pull request
Aug 1, 2023
## [4.4.5](reactjs/react-transition-group@v4.4.4...v4.4.5) (2022-08-01) ### Bug Fixes * apply entering animation synchronously when unmountOnExit or mountOnEnter is enabled ([#847](reactjs/react-transition-group#847)) ([1043549](reactjs/react-transition-group@1043549))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #846
This uses a way to force reflow to avoid applying a class asynchronously,
As I mentioned at #846 (comment), this is not ideal, but I'd like to avoid causing other issues by #749, so I'll reconsider it later.