Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply entering animation synchronously when unmountOnExit or mountOnEnter is enabled #847

Merged
merged 3 commits into from
Aug 1, 2022

Conversation

koba04
Copy link
Member

@koba04 koba04 commented Jul 31, 2022

Fixes #846

This uses a way to force reflow to avoid applying a class asynchronously,
As I mentioned at #846 (comment), this is not ideal, but I'd like to avoid causing other issues by #749, so I'll reconsider it later.

@koba04 koba04 merged commit 1043549 into master Aug 1, 2022
@koba04 koba04 deleted the fix-applying-enter-class-on-mount branch August 1, 2022 08:30
github-actions bot pushed a commit that referenced this pull request Aug 1, 2022
## [4.4.5](v4.4.4...v4.4.5) (2022-08-01)

### Bug Fixes

* apply entering animation synchronously when unmountOnExit or mountOnEnter is enabled ([#847](#847)) ([1043549](1043549))
@github-actions
Copy link

github-actions bot commented Aug 1, 2022

🎉 This PR is included in version 4.4.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

johnfrench3 pushed a commit to johnfrench3/transition-group-react that referenced this pull request Nov 2, 2022
## [4.4.5](reactjs/react-transition-group@v4.4.4...v4.4.5) (2022-08-01)

### Bug Fixes

* apply entering animation synchronously when unmountOnExit or mountOnEnter is enabled ([#847](reactjs/react-transition-group#847)) ([1043549](reactjs/react-transition-group@1043549))
patrickm68 added a commit to patrickm68/react-transition-group-developer that referenced this pull request Dec 1, 2022
## [4.4.5](reactjs/react-transition-group@v4.4.4...v4.4.5) (2022-08-01)

### Bug Fixes

* apply entering animation synchronously when unmountOnExit or mountOnEnter is enabled ([#847](reactjs/react-transition-group#847)) ([1043549](reactjs/react-transition-group@1043549))
shaikdev2 pushed a commit to shaikdev2/transition-group-react that referenced this pull request Jun 9, 2023
## [4.4.5](reactjs/react-transition-group@v4.4.4...v4.4.5) (2022-08-01)

### Bug Fixes

* apply entering animation synchronously when unmountOnExit or mountOnEnter is enabled ([#847](reactjs/react-transition-group#847)) ([1043549](reactjs/react-transition-group@1043549))
GreenCat1996 added a commit to GreenCat1996/react-transition-group that referenced this pull request Aug 1, 2023
## [4.4.5](reactjs/react-transition-group@v4.4.4...v4.4.5) (2022-08-01)

### Bug Fixes

* apply entering animation synchronously when unmountOnExit or mountOnEnter is enabled ([#847](reactjs/react-transition-group#847)) ([1043549](reactjs/react-transition-group@1043549))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Element appears with blinked when using CSSTransition with unmountOnExit
1 participant