This repository has been archived by the owner on Oct 26, 2018. It is now read-only.
Remove INIT_PATH
#97
Merged
Remove INIT_PATH
#97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Yes, it's just a functional difference. I did not add any tests for this functional difference yet. I'm not really sure which is more expected for the user; I'm fine removing it if we think |
| @@ -118,7 +105,8 @@ function syncReduxAndRouter(history, store, selectRouterState = SELECT_STATE) { | |||
| // trigger an unnecessary `pushState` on load | |||
| lastRoute = initialState; | |||
|
|
|||
| store.dispatch(initPath(route.path, route.state)); | |||
| const method = location.action === 'REPLACE' ? replacePath : pushPath; | |||
| store.dispatch(method(route.path, route.state, { avoidRouterUpdate: true })); | |||
There was a problem hiding this comment.
Here we can just directly use pushPath because we are avoiding a route update anyway.
kimjoar
force-pushed
the
remove-init-path
branch
from
3f68d96 to
2af7b28
Compare
|
Can you rebase this? I will merge it in. |
kimjoar
force-pushed
the
remove-init-path
branch
from
2af7b28 to
a985b5b
Compare
|
@jlongster Rebased |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No tests fail, so not sure we need this constant? We should either add a failing test or remove it.
The use case for removing this is receiving the initial URL when using
UPDATE_PATH, e.g. #96.(So the functional difference is: do we notify the initial route or only changes from the initial route?)