Skip to content
This repository has been archived by the owner on Oct 26, 2018. It is now read-only.

Update README and add CHANGELOG #93

Merged
merged 1 commit into from
Dec 10, 2015
Merged

Update README and add CHANGELOG #93

merged 1 commit into from
Dec 10, 2015

Conversation

justingreenberg
Copy link
Contributor

Resolves #84

👉 Preview updated README

Clean up README and update syntax for #89

- [`syncReduxAndRouter(history, store, selectRouterState?)`](#syncreduxandrouter)
- [`routeReducer`](#routereducer)
- [`UPDATE_PATH`](#update-path)
- [`updatePath(pathname, noRouterUpdate)`](#updatepath)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This api doesn't exist anymore. See #90

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(And that would of course change more with #89 ;))

redux state and keeps it in sync with any react-router changes.
Additionally, you can change the URL via redux and react-router will
change accordingly.
##### _What about redux-router?_
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move all of this redux-router stuff to the bottom, and focus on the usage and API first and foremost. Might be @jlongster disagrees, though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will essentially replace redux-router and that will live as its own standalone project. -- #80

based on the above, it seems like rackt is moving away from redux-router, so this section probably won't be around for much longer... but since many people are already using redux-router, it might a good idea to leave this for the time being

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe adding a migration guide or example would be a good idea

migrating from redux-router? use this commit as a reference

@justingreenberg justingreenberg changed the title Update README Update README and add CHANGELOG Dec 8, 2015
### Breaking

The `updatePath(path, noRouterUpdate)` action creator has been removed in favor of
`pushPath(path, state, avoidRouterUpdate)` and `replacePath(path, state, avoidRouterUpdate)`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe:

The updatePath action creator has been removed in favor of pushPath and replacePath (#38)

Other breaking changes:

Other:

@kimjoar
Copy link
Collaborator

kimjoar commented Dec 8, 2015

@jlongster Got time to take a look? Would be nice to get 1.0 out.

@@ -1,75 +1,62 @@
# [redux-simple-router](#docs)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link doesn't work right now.

(And I can't remember seeing other's link like this in the main headline, so I'm not sure we should do it. Maybe just remove the link? If it's too far down to the documentation, it just means we should remove some of the text above it)

@jlongster
Copy link
Member

Thanks a lot, this looks good. I think I'm going to remove the table of contents though. Half the links are already broken probably because we changed headers.

jlongster added a commit that referenced this pull request Dec 10, 2015
@jlongster jlongster merged commit 53097f0 into reactjs:master Dec 10, 2015
@jlongster
Copy link
Member

Just pushed 1.0.0.

@kimjoar
Copy link
Collaborator

kimjoar commented Dec 10, 2015

🎉

@gavacho
Copy link

gavacho commented Dec 10, 2015

Thanks so much for your hard work friends, I'm really enjoying working with this library!

@justingreenberg justingreenberg deleted the update-readme branch January 6, 2016 06:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants