This repository has been archived by the owner on Oct 26, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to clean up the tests so they have less duplication and rely less on checking
changeId
, but focus more on checking what actually triggershistory.listen
(i.e. the external api for these changes). This should make it easier to tests changes to how we stop cycles.I removed the test named "does not unnecessarily update the store", but added a "only triggers once when updating path via store" (which I created as part of #109, where I have a test which covers
history.pushState
).