Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: specify yarn as package manager and remove unused dependency #1331

Merged
merged 3 commits into from
Jan 10, 2024
Merged

chore: specify yarn as package manager and remove unused dependency #1331

merged 3 commits into from
Jan 10, 2024

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Jan 10, 2024

Summary

With #1306 landed we now support any of the main package managers which includes for our internal plumbing, and since we're not specifying a package manager npm is being used by default which is highlighting a peer dependency conflict with react-transition-group - it turns out that we don't actually need this package anymore so it can just go, but I've also explicitly set the packageManager to be yarn since that is what was being used before.

Since this is also touching the package.json files, I figured it would be a good time to slip in running sort-package-json for consistency.

Pull Request checklist

Remove this line after checking all the items here. If the item is not applicable to the PR, both check it out and wrap it by ~.

  • Add/update test to cover these changes
  • Update documentation
  • Update CHANGELOG file

@justin808 justin808 merged commit 49090a4 into reactjs:master Jan 10, 2024
19 checks passed
@G-Rath G-Rath deleted the update-package-jsons branch January 10, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants