Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failures #1326

Closed
wants to merge 6 commits into from
Closed

Fix test failures #1326

wants to merge 6 commits into from

Conversation

ahangarha
Copy link
Collaborator

@ahangarha ahangarha commented Jan 1, 2024

Summary

This PR fixes some of the recent test failures.

Other Information

The change is based on the discussions in SeleniumHQ/selenium#13112.

Pull Request checklist

  • Add/update test to cover these changes
  • Update documentation
  • Update CHANGELOG file

@G-Rath
Copy link
Contributor

G-Rath commented Jan 1, 2024

@ahangarha next thing to try would be to use headless=new, based on SeleniumHQ/selenium#13112

This reverts commit 5311cbe.
@ahangarha ahangarha changed the title WIP - Test exisitng situation WIP - Fix test failures Jan 2, 2024
@ahangarha ahangarha changed the title WIP - Fix test failures Fix test failures Jan 2, 2024
@ahangarha ahangarha marked this pull request as ready for review January 2, 2024 14:51
@G-Rath
Copy link
Contributor

G-Rath commented Jan 2, 2024

See #1328 (comment) - this looks like the fix for after updating selenium-webdriver but it still means the lockfiles are actually incorrect for Ruby 2.7, so I think we should land #1328 first then land this after a rebase + redoing the general update from #1302

@ahangarha
Copy link
Collaborator Author

If the issue is resolved (it seems it is) I close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants