Moves classnames to dependencies #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it a bit more compatible with the way peerDependencies will work in `npm@3` later down the line. It also makes it so that consumers of the lib can have another version of classnames at the app level while not requiring this particular lib to require a version bump. Plus, this lib sorta depends on it and should it need to be locked down to a particular version, this lib should manage that rather than expect it to happen at the app level.
|
+1 |
mzabriskie
added a commit
that referenced
this pull request
Jul 15, 2015
Moves classnames to dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it a bit more compatible with the way peerDependencies will work in
npm@3later down the line.It also makes it so that consumers of the lib can have another version of classnames at the app level while
not requiring this particular lib to require a version bump. Plus, this lib sorta depends on it and should
it need to be locked down to a particular version, this lib should manage that rather than expect it to
happen at the app level.