New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] fix onRequestClose callback in Usage #195

Merged

claydiffrient merged 1 commit into reactjs:master from dvdzkwsk:patch-2

Jun 30, 2016

Contributor

dvdzkwsk commented Jun 30, 2016

Changes proposed:

Makes the primary Usage example more idiomatic and consistent with the example in https://github.com/reactjs/react-modal#testing.

Upgrade Path (for changed or removed APIs):

N/A

Acceptance Checklist:

All commits have been squashed to one.
The commit message follows the guidelines in CONTRIBUTING.md.
Documentation (README.md) and examples have been updated as needed.
If this is a code change, a spec testing the functionality has been added.
If the commit message has [changed] or [removed], there is an upgrade path above.


          [doc] fix onRequestClose callback in Usage

801e73f

claydiffrient merged commit f0933fd into reactjs:master

dvdzkwsk deleted the patch-2 branch

June 30, 2016 23:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet