Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal opened by using mouse right click was not closed even if I clicked ModalPortal. #590

Closed
Jongkeun opened this issue Jan 9, 2018 · 4 comments · Fixed by #591
Closed
Labels

Comments

@Jongkeun
Copy link
Contributor

Jongkeun commented Jan 9, 2018

React-modal is not closed at first click on Linux.
If Modal is opened by mouse right click like a contextmenu, the modal is closed by twice clicking.
A modal that I opened as mouse left click is normal.
And the strange situation is broken only on Linux.

Steps to reproduce:

  1. click the button using mouse right click.
  2. click a background using mouse left click. The modal is not closed.
  3. click a background using mouse left click again. Then the modal is closed.

Expected behavior:

I need to close it at once although I opened a modal using mouse right click.

Link to example of issue:

this is sample code

Additional notes:

Thank you for your project.

Jongkeun added a commit to Jongkeun/react-modal that referenced this issue Jan 9, 2018
@diasbruno
Copy link
Collaborator

This is a very curious scenario. It is also reproducible on Safari (OS X).

@diasbruno diasbruno added the bug label Jan 9, 2018
@Jongkeun
Copy link
Contributor Author

Jongkeun commented Jan 9, 2018

It is normal until version 2.3.3.

@diasbruno
Copy link
Collaborator

Thanks. I'll check if something has changed on the handlers from 2.3.3..latest.

@Jongkeun
Copy link
Contributor Author

Jongkeun commented Jan 9, 2018

Check the pull request.
I added some code.
I don’t know if that is right.
Anyway I hope to fixed soon.
Cheer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants