Skip to content

Commit

Permalink
[changed] Replace appElement with getAppElement
Browse files Browse the repository at this point in the history
This makes getAppElement a required prop as well as makes
it a function that will be called expecting a DOMElement.

closes #287

This also takes some inspiration from #359 for handling arrays
of objects.

Upgrade Path:
  - If you had specified an appElement via `Modal.setAppElement`,
    then you need to convert that to a getAppElement prop on the
    modal, this should be a function that returns either a single
    element or an array of elements.
  - If you had nothing specified you will need to add the getAppElement
    element to prevent beakages.
  • Loading branch information
claydiffrient committed Mar 26, 2017
1 parent 9cb8441 commit 7940ea0
Show file tree
Hide file tree
Showing 3 changed files with 163 additions and 117 deletions.
Loading

0 comments on commit 7940ea0

Please sign in to comment.