Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve flow $Keys<> to union type #225

Merged
merged 2 commits into from
Nov 9, 2017
Merged

Resolve flow $Keys<> to union type #225

merged 2 commits into from
Nov 9, 2017

Conversation

danez
Copy link
Collaborator

@danez danez commented Oct 22, 2017

resolveObjectExpressionToNameArray could be extracted into a separate handler, but I tried to keep the diff for now as minimal as possible

Fixes #154

@danez danez added this to the v2 milestone Oct 22, 2017
@danez danez merged commit 9ef2f84 into reactjs:master Nov 9, 2017
@danez danez deleted the flow-keys branch November 9, 2017 20:52
@s-h-a-d-o-w s-h-a-d-o-w mentioned this pull request Oct 25, 2018
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
v2
Development

Successfully merging this pull request may close these issues.

Trouble following $Keys when using Flowtype for Props
1 participant
@danez