-e parameter now handle regular espression #164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Today I discovered I need this feature, also. Can someone on the My usecase is this: I want to point to a I tried this PR and passed in I would love it if this got merged in :-) |
|
I will look at it over the weekend! |
fkling
reviewed
May 31, 2017
bin/react-docgen.js
Outdated
| @@ -68,6 +68,11 @@ var ignoreDir = argv.ignore; | |||
| var excludePatterns = argv.exclude; | |||
| var resolver; | |||
| var errorMessage; | |||
| var regexRegex = /\/(.*)\/([igymu]{0,5})/; | |||
There was a problem hiding this comment.
The pattern should be anchored:
/^\/(.*)\/([igymu]{0,5})$/;
Otherwise it looks fine to me!
|
Merged as d9782c8 . Will release a new version soon. |
|
Released v2.16.0! v3 beta will follow. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if only one -e parameter is passed to cli and the value matches /.*/[gmiuy]{0,5} then this is treated as a Regular Expression