Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: translate link #718

Merged
merged 11 commits into from
Jul 26, 2024
Merged

docs: translate link #718

merged 11 commits into from
Jul 26, 2024

Conversation

farisadlin
Copy link
Contributor

@farisadlin farisadlin commented Jul 20, 2024 •
edited
Loading

Closes #686

Description

Translate the Link page.
Page URL: https://id.react.dev/reference/react-dom/components/link

@vercel Vercel
Copy link

vercel bot commented Jul 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
id-legacy-reactjs-org ⬜️ Ignored (Inspect) Visit Preview Jul 23, 2024 11:28am

@farisadlin
Copy link
Contributor Author

This PR is ready for review @resir014

@farisadlin farisadlin changed the title [FEATURE] Done Translating Link Component to Indonesian docs: Done Translating Link Component to Indonesian Jul 20, 2024
@farisadlin farisadlin changed the title docs: Done Translating Link Component to Indonesian docs: done translating link component to indonesian Jul 20, 2024
@farisadlin farisadlin changed the title docs: done translating link component to indonesian docs: translate link Jul 20, 2024
r17x
r17x requested changes Jul 20, 2024
View reviewed changes
Copy link
Collaborator

@r17x r17x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gunakan asterisk (*) dari pada _.

  • _stylesheet_ -> *stylesheet*

@farisadlin farisadlin requested a review from r17x July 21, 2024 06:36
@farisadlin
Copy link
Contributor Author

farisadlin commented Jul 21, 2024 •
edited
Loading

Gunakan asterisk (*) dari pada _.

  • _stylesheet_ -> *stylesheet*

Thank you, Mas @r17x, for the review. I've done the revision; please re-review it again.

Thank you

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 21, 2024 •
edited
Loading

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 105.13 KB (-5 B) 209.33 KB
/500 105.13 KB (-5 B) 209.32 KB
/[[...markdownPath]] 107.02 KB (-5 B) 211.21 KB
/errors 105.34 KB (-5 B) 209.54 KB
/errors/[errorCode] 105.32 KB (-5 B) 209.52 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

resir014
resir014 requested changes Jul 22, 2024
View reviewed changes
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change needed. Always capitalise beginnings of sentences. @farisadlin

src/content/reference/react-dom/components/link.md Outdated

These props apply when `rel="stylesheet"`:
*props* ini berlaku ketika `rel="stylesheet"`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*props* ini berlaku ketika `rel="stylesheet"`:
*Props* ini berlaku ketika `rel="stylesheet"`:

Capitalise this since it's in the beginning of the sentence.

src/content/reference/react-dom/components/link.md Outdated

These props apply when `rel="preload"` or `rel="modulepreload"`:
*props* ini berlaku ketika `rel="preload"` atau `rel="modulepreload"`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*props* ini berlaku ketika `rel="preload"` atau `rel="modulepreload"`:
*Props* ini berlaku ketika `rel="preload"` atau `rel="modulepreload"`:

src/content/reference/react-dom/components/link.md Outdated

These props apply when `rel="icon"` or `rel="apple-touch-icon"`:
*props* ini berlaku ketika `rel="icon"` atau `rel="apple-touch-icon"`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*props* ini berlaku ketika `rel="icon"` atau `rel="apple-touch-icon"`:
*Props* ini berlaku ketika `rel="icon"` atau `rel="apple-touch-icon"`:

src/content/reference/react-dom/components/link.md Outdated

These props apply in all cases:
*props* ini berlaku dalam semua kasus:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*props* ini berlaku dalam semua kasus:
*Props* ini berlaku dalam semua kasus:

src/content/reference/react-dom/components/link.md Outdated

Props that are **not recommended** for use with React:
*props* yang **tidak direkomendasikan** untuk digunakan dengan React:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*props* yang **tidak direkomendasikan** untuk digunakan dengan React:
*Props* yang **tidak direkomendasikan** untuk digunakan dengan React:

src/content/reference/react-dom/components/link.md Outdated

</Canary>

<Intro>

The [built-in browser `<link>` component](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link) lets you use external resources such as stylesheets or annotate the document with link metadata.
[komponen `<link>` bawaan peramban](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link) memungkinkan Anda menggunakan sumber daya eksternal seperti *stylesheet* atau memberi anotasi pada dokumen dengan metadata tautan.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[komponen `<link>` bawaan peramban](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link) memungkinkan Anda menggunakan sumber daya eksternal seperti *stylesheet* atau memberi anotasi pada dokumen dengan metadata tautan.
[Komponen `<link>` bawaan peramban](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link) memungkinkan Anda menggunakan sumber daya eksternal seperti *stylesheet* atau memberi anotasi pada dokumen dengan metadata tautan.

Always capitalise beginnings of sentences.

resir014
resir014 reviewed Jul 23, 2024
View reviewed changes
src/content/reference/react-dom/components/link.md Outdated

#### Props {/*props*/}
#### *props* {/*props*/}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### *props* {/*props*/}
#### *Props* {/*props*/}

@farisadlin farisadlin requested a review from resir014 July 23, 2024 11:28
@farisadlin
Copy link
Contributor Author

Thank you for the review, @resir014. I've done the fix. Please re-check it again

@resir014 resir014 merged commit 29476ff into reactjs:main Jul 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r17x r17x r17x approved these changes

@resir014 resir014 resir014 approved these changes

@zainfathoni zainfathoni Awaiting requested review from zainfathoni

@mhaidarhanif mhaidarhanif Awaiting requested review from mhaidarhanif

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<link>
3 participants
@farisadlin @resir014 @r17x