Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate DOM Elements #59

Merged
merged 7 commits into from
Feb 4, 2019
Merged

Translate DOM Elements #59

merged 7 commits into from
Feb 4, 2019

Conversation

LuisRevillaM
Copy link
Contributor

@LuisRevillaM LuisRevillaM commented Feb 2, 2019

Translating DOM Elements section of the API Reference to Spanish.
Relates to issue #25

@LuisRevillaM LuisRevillaM changed the title WIP: Translate DOM Elements section Translate DOM Elements Feb 2, 2019
@LuisRevillaM
Copy link
Contributor Author

I think I don't have permissions to assign you the PR, so I'm mentioning you here @dmoralesm , @carburo, @alejandronanez. Thank you!

Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @LuisRevillaM for your contribution! I made some suggestions that I think should be addressed before merging.

content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
@LuisRevillaM
Copy link
Contributor Author

Thank you @LuisRevillaM for your contribution! I made some suggestions that I think should be addressed before merging.

I just committed the changes. Thanks for the suggestions! The translation is much better now.

@carburo
Copy link
Member

carburo commented Feb 4, 2019

Looks great! Thanks.
Merging

@carburo carburo merged commit 29820cb into reactjs:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants