Fix AjaxTimeoutErrorImpl to extend AjaxError #5226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed AjaxTimeoutError not inheriting AjaxError's and Eerror's prototype. While the TypeScript typings were correct, actual code using instanceof operator would fail. The following statements are now true: * AjaxError instanceof Error === true * AjaxTimeoutError instanceof Error === true * AjaxTimeoutError instanceof AjaxError === true
benlesh
approved these changes
Jan 20, 2020
martinsik
pushed a commit
to martinsik/rxjs
that referenced
this pull request
Feb 15, 2020
* fix ajax: AjaxTimeoutError should extend AjaxError Fixed AjaxTimeoutError not inheriting AjaxError's and Eerror's prototype. While the TypeScript typings were correct, actual code using instanceof operator would fail. The following statements are now true: * AjaxError instanceof Error === true * AjaxTimeoutError instanceof Error === true * AjaxTimeoutError instanceof AjaxError === true * docs: CONTRIBUTING.ms was referencing Jasmine instead of Chai.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed AjaxTimeoutError not inheriting AjaxError's and Eerror's
prototype. While the TypeScript typings were correct, actual code
using instanceof operator would fail.
The following statements are now true: