Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AjaxTimeoutErrorImpl to extend AjaxError #5226

Merged
merged 2 commits into from
Jan 20, 2020
Merged

Fix AjaxTimeoutErrorImpl to extend AjaxError #5226

merged 2 commits into from
Jan 20, 2020

Commits on Jan 10, 2020

  1. fix ajax: AjaxTimeoutError should extend AjaxError 

    Fixed AjaxTimeoutError not inheriting AjaxError's and Eerror's
prototype. While the TypeScript typings were correct, actual code
using instanceof operator would fail.

The following statements are now true:
* AjaxError instanceof Error === true
* AjaxTimeoutError instanceof Error === true
* AjaxTimeoutError instanceof AjaxError === true
    @Huulivoide
    Huulivoide committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    cbe789f View commit details
    Browse the repository at this point in the history

  2. docs: CONTRIBUTING.ms was referencing Jasmine instead of Chai.

    @Huulivoide
    Huulivoide committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    44c4cfd View commit details
    Browse the repository at this point in the history