fix(defer): restrict allowed factory types #4835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartant
referenced
this pull request
Jun 5, 2019
* test(defer): add failing dtslint test * fix(defer): use overload sig for void factory Closes #4804
benlesh
requested changes
Jun 5, 2019
|
Added the missing test. |
benlesh
approved these changes
Jun 6, 2019
benlesh
approved these changes
Jun 6, 2019
benlesh
pushed a commit
that referenced
this pull request
Jun 6, 2019
* test(defer): add failing dtslint test * fix(defer): restrict allowed factory types * test(defer): add a sometimes-returns dtslint test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes a problem with the
defertype signatures that was introduced in #4810 - the PR that ensured thatObservable<never>was inferred for factory functions that returnvoid.The problem was that
() => voidwill match functions returning any value - as the return value is ignored - which meant that factories could return anything - e.g. anumber.See the discussion on this commit.
The PR includes a failing dtslint test that is fixed by the change.
Related issue (if exists): #4804 #4810