fix(defer): use overload sig for void factory (#4810)

* test(defer): add failing dtslint test * fix(defer): use overload sig for void factory Closes #4804
ReactiveX · Jun 4, 2019 · 362d1d4 · 362d1d4 · mhverbakel · Jun 5, 2019
1 parent 9d823df
commit 362d1d4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/spec-dtslint/observables/defer-spec.ts b/spec-dtslint/observables/defer-spec.ts
@@ -15,3 +15,7 @@ it('should infer correctly with function return promise', () => {
 it('should support union type returns', () => {
   const a = defer(() => Math.random() > 0.5 ? of(123) : of('abc')); // $ExpectType Observable<string | number>
 });
+
+it('should infer correctly with void functions', () => {
+  const a = defer(() => {}); // $ExpectType Observable<never>
+});
diff --git a/src/internal/observable/defer.ts b/src/internal/observable/defer.ts
@@ -52,6 +52,8 @@ import { empty } from './empty';
  * @name defer
  * @owner Observable
  */
+export function defer<O extends ObservableInput<any>>(observableFactory: () => O): Observable<ObservedValueOf<O>>;
+export function defer(observableFactory: () => void): Observable<never>;
 export function defer<O extends ObservableInput<any>>(observableFactory: () => O | void): Observable<ObservedValueOf<O>> {
   return new Observable<ObservedValueOf<O>>(subscriber => {
     let input: O | void;