-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Added Uno support #2067
Conversation
src/ReactiveUI.Wpf/obj/Debug/net461/GeneratedInternalTypeHelper.g.cs
Outdated
Show resolved
Hide resolved
Looks like generic type arguments are not supported. Opened suggestion. Anyway the solution I'm thinking of, is having on each view code-behind a dummy class that inherits from <v:ReactiveMainPage
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
xmlns:v="using:MyProject.Views"
x:Class="MyProject.Views.MainPage"
/> namespace MyProject.Views
{
public class ReactiveMainPage : ReactiveUserControl<MainPageViewModel>
{
}
public sealed partial class MainPage : ReactiveMainPage
{
}
} I'd be happy to hear about any other ideas of course. |
|
@jeromelaban can u take a look around here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@glennawatson Perhaps revert this commit, I opened #2078 for that. |
Leave it in, I'm going to check some stuff the blazer guys did which would affect that portion of the code. |
Thank you guys for the hard work, you're amazing! |
feature: Added Uno support (reactiveui#2067)
This PR adds initial support for the Uno Platform.