Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid importing testing module #907

Merged
merged 2 commits into from
Feb 3, 2023
Merged

avoid importing testing module #907

merged 2 commits into from
Feb 3, 2023

Conversation

rmorshea
Copy link
Collaborator

@rmorshea rmorshea commented Feb 3, 2023 •
edited
Loading

closes: #906

Checklist

Please update this checklist as you complete each item:

  • Tests have been included for all bug fixes or added functionality.
  • The changelog.rst has been updated with any significant changes.
  • GitHub Issues which may be closed by this Pull Request have been linked.

@rmorshea rmorshea marked this pull request as ready for review February 3, 2023 02:07
@rmorshea rmorshea requested a review from Archmonger February 3, 2023 02:09
@rmorshea rmorshea force-pushed the avoid-testing-import branch 2 times, most recently from ac1f907 to a85aa6c Compare February 3, 2023 02:18
@rmorshea rmorshea force-pushed the avoid-testing-import branch from a85aa6c to 58b57b2 Compare February 3, 2023 02:21
Archmonger
Archmonger previously approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@Archmonger Archmonger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to bundle a version bump into this PR

@rmorshea
Copy link
Collaborator Author

rmorshea commented Feb 3, 2023

Have another PR to fix the type hint issue as well

@rmorshea rmorshea merged commit aa26caa into main Feb 3, 2023
@rmorshea rmorshea deleted the avoid-testing-import branch February 3, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Archmonger Archmonger Archmonger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove accidental playwright dependency
2 participants
@rmorshea @Archmonger