Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow users to configure html head #835

Merged
merged 19 commits into from
Nov 29, 2022
Merged

allow users to configure html head #835

merged 19 commits into from
Nov 29, 2022

Conversation

rmorshea
Copy link
Collaborator

@rmorshea rmorshea commented Nov 14, 2022

closes: #834
closes: #435

Checklist

Please update this checklist as you complete each item:

  • Tests have been included for all bug fixes or added functionality.
  • The changelog.rst has been updated with any significant changes.
  • GitHub Issues which may be closed by this Pull Request have been linked.

@rmorshea rmorshea changed the title allow users to configure html head draft: allow users to configure html head Nov 14, 2022
src/idom/utils.py Outdated Show resolved Hide resolved
@rmorshea rmorshea force-pushed the config-head branch 3 times, most recently from a2671d7 to f9ba4e8 Compare November 19, 2022 20:47
@rmorshea rmorshea changed the title draft: allow users to configure html head allow users to configure html head Nov 19, 2022
@rmorshea rmorshea requested a review from Archmonger November 19, 2022 21:13
docs/source/about/changelog.rst Outdated Show resolved Hide resolved
src/idom/utils.py Outdated Show resolved Hide resolved
src/idom/utils.py Outdated Show resolved Hide resolved
src/idom/utils.py Outdated Show resolved Hide resolved
@rmorshea rmorshea force-pushed the config-head branch 2 times, most recently from 67dfb58 to 98b4265 Compare November 22, 2022 04:28
@rmorshea rmorshea requested a review from Archmonger November 22, 2022 23:51
Copy link
Contributor

@Archmonger Archmonger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks pretty good, mostly minor nitpicks

src/idom/utils.py Outdated Show resolved Hide resolved
src/idom/utils.py Outdated Show resolved Hide resolved
src/idom/utils.py Outdated Show resolved Hide resolved
src/idom/utils.py Outdated Show resolved Hide resolved
src/idom/utils.py Outdated Show resolved Hide resolved
src/idom/utils.py Outdated Show resolved Hide resolved
@rmorshea rmorshea merged commit 97c0f42 into main Nov 29, 2022
@rmorshea rmorshea deleted the config-head branch November 29, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to configure client <head/> add VDOM to HTML util function
2 participants