-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow users to configure html head #835
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmorshea
changed the title
allow users to configure html head
draft: allow users to configure html head
Nov 14, 2022
Archmonger
reviewed
Nov 14, 2022
rmorshea
force-pushed
the
config-head
branch
3 times, most recently
from
November 19, 2022 20:47
a2671d7
to
f9ba4e8
Compare
rmorshea
changed the title
draft: allow users to configure html head
allow users to configure html head
Nov 19, 2022
Archmonger
requested changes
Nov 21, 2022
Archmonger
reviewed
Nov 22, 2022
rmorshea
force-pushed
the
config-head
branch
2 times, most recently
from
November 22, 2022 04:28
67dfb58
to
98b4265
Compare
Archmonger
requested changes
Nov 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks pretty good, mostly minor nitpicks
rmorshea
force-pushed
the
config-head
branch
from
November 23, 2022 00:51
ca0f125
to
c0e1248
Compare
rmorshea
force-pushed
the
config-head
branch
from
November 23, 2022 20:17
49b53a6
to
fe485d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #834
closes: #435
Checklist
Please update this checklist as you complete each item:
changelog.rst
has been updated with any significant changes.