-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vite #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@acivitillo, I don't know if you're still using IDOM, but if you are, this may impact you. If you're using a |
rmorshea
force-pushed
the
vite
branch
3 times, most recently
from
October 29, 2022 23:00
efe272b
to
d53ad83
Compare
Archmonger
approved these changes
Oct 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #796
This is low priority, but unfortunately it involves some API changes that I'd like to get out of the way. Currently, the server exposes the following interface:
This lead to some complicated route patterns. Under these changes though, the server exposes a simpler interface:
Here, all of IDOM's core server APIs are housed under a
/_idom
root URL. This makes it simpler for the client to direct requests to the correct location and, I assume, makes it possible for the browser to cache static resources. The only complication is that the client needs to coordinate requesting/_idom/stream/<spa-path>
where<spa-path>
is the same from/<spa-path>
where the SPA is being hosted. Backend implementations should then normalize<spa-path>
when constructingConnection.location
by stripping any URL prefix.Checklist
Please update this checklist as you complete each item:
changelog.rst
has been updated with any significant changes.