Fix state mismatch during component update #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmorshea
requested changes
Jan 29, 2022
|
Let me know if you think this is safe. I'm slightly worried this exception may have occurred due to an incomplete wipe of component hooks on key change. If so, then this would be a memory leak. But I don't know enough about the layout call stack to say anything with certainty. |
rmorshea
approved these changes
Jan 29, 2022
|
I think it's ok. I'm pretty certain I introduced this because I didn't really understand how keys worked very well. |
|
We unmount on the same condition here so we should be avoiding the memory leak. |
|
I'll have time to release this tomorrow. |
rmorshea
approved these changes
Jan 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something worth thinking about is whether this error had actually existed due to the previous state hook not being deleted from memory. Just want to ensure there are no memory leaks occurring.