Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Use Context Hook #585

Merged
merged 2 commits into from
Feb 21, 2022
Merged

Add Use Context Hook #585

merged 2 commits into from
Feb 21, 2022

Conversation

rmorshea
Copy link
Collaborator

Task from: #203

@rmorshea rmorshea marked this pull request as ready for review January 17, 2022 18:43
@Archmonger
Copy link
Contributor

Archmonger commented Feb 14, 2022 •
edited
Loading

Should this PR encompass #594 or should I open a separate issue specifically for RequestContext on a per-framework basis?

@rmorshea
Copy link
Collaborator Author

I think it should be a separate issue. use_context has other applications besides just the request context

@rmorshea rmorshea mentioned this pull request Feb 15, 2022
Closed
@rmorshea rmorshea force-pushed the use_context branch 9 times, most recently from cd61fff to a70ed0f Compare February 20, 2022 20:47
@rmorshea rmorshea merged commit 82a7edf into main Feb 21, 2022
@rmorshea rmorshea deleted the use_context branch February 21, 2022 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmorshea @Archmonger