-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deferred static files #77
Conversation
Co-authored-by: Ryan Morshead <[email protected]>
@rmorshea This PR is still a draft, I have a bit more to work on. I will mark as "Ready for review" when complete. |
This reverts commit 0ffb5a5.
@rmorshea Would you have time to review this weekend? |
I'll try to get to this today or tomorrow. |
apologies. i will make time tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor things here and there. Besides that, LGTM!
Co-authored-by: Ryan Morshead <[email protected]>
Co-authored-by: Ryan Morshead <[email protected]>
Co-authored-by: Ryan Morshead <[email protected]>
Can't merge without re-approval. |
This PR adds a
static_css
component, which reads the CSS file's from disk, stores the contents in cache (for performance purposes), and then puts the file contents into ahtml.style
tag.Currently, IDOM has no real way to "wait for CSS to load". This will lead to visual jank when attempting to use
html.link
to defer load CSS loading until a certain component exists. For example, visual jank occurs when usingThis also mitigates the need for the following (within Django only):
Changelog
idom-team/idom