Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Shippo and rate handling in order fulfillment #1847

Merged
merged 6 commits into from
Feb 21, 2017

Conversation

aaronjudd
Copy link
Contributor

@aaronjudd aaronjudd commented Feb 16, 2017

Resolves #1778
Resolves #1785

Adds a "Generate Rates" button for whenever a flat rate hasn't been used. Adds method "shipping/status/refresh" that is a stub to be observed to trigger updates (in the case of multiple packages that need to refresh rates). Adds updated handling for flat rate editing, to be aware of other shipping views. Adds print label into the shipment section. Update UI elements in shipping details.

To test, walk through both a flat rate, and a shippo calculated rate checkout, then fulfillment.

Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Customs label is not showing for international address.
  • i18n isn't initializing on Shipping Label button initially, but shows after items are shipped

Aaron Judd added 2 commits February 16, 2017 20:10
- Not all services support customs label generation, test with USPS.
- adds error handling if customs declaration hasn’t been configured.
@aaronjudd aaronjudd dismissed kieckhafer’s stale review February 17, 2017 18:00

#1862 created to add customs declarations. Error handling for shippo label generation added.

The Shipping Label error is a long message, we need to add a couple
seconds to the Toast Alert timeout to allow time to read it. Changed
from 5000ms to 7000ms
@aaronjudd aaronjudd changed the title Updated Shippo and rate handling in order fulfillment [WIP] Updated Shippo and rate handling in order fulfillment Feb 17, 2017
@aaronjudd aaronjudd changed the title [WIP] Updated Shippo and rate handling in order fulfillment Updated Shippo and rate handling in order fulfillment Feb 21, 2017
@aaronjudd
Copy link
Contributor Author

WIP removed, @kieckhafer created issue for a more elegant shipping loader #1872

@kieckhafer kieckhafer merged commit 4c18abb into development Feb 21, 2017
@kieckhafer kieckhafer deleted the 1778-shippo-handling branch February 21, 2017 18:28
@kieckhafer kieckhafer removed the review label Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants