Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove card cursor:pointer #1384

Merged
merged 1 commit into from
Sep 16, 2016
Merged

remove card cursor:pointer #1384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion imports/plugins/included/default-theme/client/styles/cards.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
.rui.card .content {
.flex(1 1 auto);
padding: 10px;
cursor: pointer;
cursor: default;
Copy link
Member

@mikemurray mikemurray Sep 14, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why even have the cursor at all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you suggesting that you don't think the card should be clickable at all? Just the little > section?

Copy link
Member

@mikemurray mikemurray Sep 16, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That the cursor: default is not necessary if its not overriding anything.

For future consideration
Looking forward to Bootstrap 4 cards: http://v4-alpha.getbootstrap.com/components/card/

I feel like maybe the clickable content might be confusing since there are other action buttons in the card as well. Maybe we always force the use of the arrow buttons, and make them bigger.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That the cursor: default is not necessary if its not overriding anything. but it is.. because the cards are clickable by default.. the logic to add/remove the anchor is missing from the card component.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok then, this is good for now.

}

.rui.card .content .title {
Expand Down