Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why @react-workspaces/react-scripts and react-scripts required as dependencies in same app #36

Open
Jagatmachines opened this issue Feb 20, 2020 · 2 comments

Comments

@Jagatmachines
Copy link

@F1LT3R
Copy link
Collaborator

F1LT3R commented Apr 29, 2020

Well whoever committed that line was obviously an idiot.

Care to remove and submit PR?

@alanrubin
Copy link

alanrubin commented May 6, 2020

Just a heads-up, I have removed react-scripts and starting getting issues with import of svg files, after some research I found that facebook/create-react-app#8223

That means that after you remove the react-scripts, you will need to modify all react-app-env.d.ts files from:

/// <reference types="react-scripts" />

to

/// <reference types="@react-workspaces/react-scripts" />

After I have done that, the imports worked again. Obviously that is relevant only for people using Typescript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants