Merge pull request #30 from jmyrland/fix-issue-29

Fix related to issue #29
react-workspaces · Jan 29, 2020 · 2430281 · 2430281
2 parents 6dadcc5 + 425b518
commit 2430281
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/.gitignore b/.gitignore
@@ -54,9 +54,6 @@ typings/
 # Yarn Integrity file
 .yarn-integrity
 
-# dotenv environment variables file
-.env
-
 # next.js build output
 .next
 

diff --git a/packages/apps/app-typescript/.env b/packages/apps/app-typescript/.env
@@ -0,0 +1,2 @@
+# Required for running external components!
+EXTEND_ESLINT=true
diff --git a/packages/components-typescript/.eslintrc.js b/packages/components-typescript/.eslintrc.js
@@ -1,8 +1,11 @@
 module.exports = {
   parser: '@typescript-eslint/parser', // Specifies the ESLint parser
   extends: [
-    'plugin:react/recommended', // Uses the recommended rules from @eslint-plugin-react
-    'plugin:@typescript-eslint/recommended', // Uses the recommended rules from @typescript-eslint/eslint-plugin
+    // Extend on the config used in `react-scripts`
+    require.resolve('eslint-config-react-app'),
+    // If you want extra rules/extensions, it can be added here:
+    // 'plugin:react/recommended', // Uses the recommended rules from @eslint-plugin-react
+    // 'plugin:@typescript-eslint/recommended', // Uses the recommended rules from @typescript-eslint/eslint-plugin
   ],
   parserOptions: {
     ecmaVersion: 2018, // Allows for the parsing of modern ECMAScript features
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		# Required for running external components!
		EXTEND_ESLINT=true