Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better form layout #44

Closed
adamkudrna opened this issue Apr 16, 2020 · 0 comments · Fixed by #93
Closed

Better form layout #44

adamkudrna opened this issue Apr 16, 2020 · 0 comments · Fixed by #93
Assignees
@adamkudrna
Labels
feature
Milestone
v0.31.0

Comments

@adamkudrna
Copy link
Member

adamkudrna commented Apr 16, 2020 •
edited
Loading

We need the option to align form fields to the input field from the left side, even when they have auto-sized labels in horizontal layout. It must also work with vertical field layout (applied also for horizontal layout on small screens).
@adamkudrna adamkudrna added this to the v0.29.0 milestone Apr 16, 2020
@adamkudrna adamkudrna self-assigned this Apr 16, 2020
adamkudrna added a commit that referenced this issue May 30, 2020
@adamkudrna
Create FormLayout component (#44)
8c8103c
adamkudrna added a commit that referenced this issue May 30, 2020
@adamkudrna
Add support for React Fragments to CardList and FormLayout (#44)
66b5cbb 
Fragments are not traversed with `React.children.map()` [1][2] so we are using the `react-keyed-flatten-children` bundle to flatten the children to a one-dimensional array. This is necessary to be able to pass props to children of these layouts.

[1] https://reactjs.org/docs/react-api.html#reactchildrenmap
[2] reactjs/rfcs#61 (comment)
adamkudrna added a commit that referenced this issue May 30, 2020
@adamkudrna
fixup! Create FormLayout component (#44)
200e5b3
adamkudrna added a commit that referenced this issue May 30, 2020
@adamkudrna
fixup! Create FormLayout component (#44)
f060727
adamkudrna added a commit that referenced this issue Jun 2, 2020
@adamkudrna
Create FormLayout component and make form fields ready for it (#44)
6ed876a
adamkudrna added a commit that referenced this issue Jun 2, 2020
@adamkudrna
Add support for React Fragments to CardList and FormLayout (#44)
3445c8e 
Fragments are not traversed with `React.children.map()` [1][2] so we are using the `react-keyed-flatten-children` bundle to flatten the children to a one-dimensional array. This is necessary to be able to pass props to children of these layouts.

[1] https://reactjs.org/docs/react-api.html#reactchildrenmap
[2] reactjs/rfcs#61 (comment)
adamkudrna added a commit that referenced this issue Jun 2, 2020
@adamkudrna
fixup! Create FormLayout component and make form fields ready for it (
e70bf08 
#44)
@adamkudrna adamkudrna mentioned this issue Jun 2, 2020
Merged
adamkudrna added a commit that referenced this issue Jun 4, 2020
@adamkudrna
fixup! fixup! Create FormLayout component and make form fields read…
8867b51 
…y for it (#44)
adamkudrna added a commit that referenced this issue Jun 5, 2020
@adamkudrna
Create FormLayout component and make form fields ready for it (#44)
9d1c196
adamkudrna added a commit that referenced this issue Jun 5, 2020
@adamkudrna
Add support for React Fragments to CardList and FormLayout (#44)
ea8ca8b 
Fragments are not traversed with `React.children.map()` [1][2] so we are using the `react-keyed-flatten-children` bundle to flatten the children to a one-dimensional array. This is necessary to be able to pass props to children of these layouts.

[1] https://reactjs.org/docs/react-api.html#reactchildrenmap
[2] reactjs/rfcs#61 (comment)
adamkudrna added a commit that referenced this issue Jun 5, 2020
@adamkudrna
Create FormLayout component and make form fields ready for it (#44)
4441aaf
adamkudrna added a commit that referenced this issue Jun 5, 2020
@adamkudrna
Add support for React Fragments to CardList and FormLayout (#44)
b8f8d36 
Fragments are not traversed with `React.children.map()` [1][2] so we are using the `react-keyed-flatten-children` bundle to flatten the children to a one-dimensional array. This is necessary to be able to pass props to children of these layouts.

[1] https://reactjs.org/docs/react-api.html#reactchildrenmap
[2] reactjs/rfcs#61 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamkudrna adamkudrna

Labels
feature
Projects
None yet
Milestone
v0.31.0
Development

Successfully merging a pull request may close this issue.

Create FormLayout component react-ui-org/react-ui
1 participant
@adamkudrna