fix(types): fix various types (#6)

react-restart · May 24, 2021 · 2bc0639 · 2bc0639
1 parent 344a52d
commit 2bc0639
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/src/Anchor.tsx b/src/Anchor.tsx
@@ -18,7 +18,7 @@ const propTypes = {
   onKeyDown: PropTypes.func,
   disabled: PropTypes.bool,
   role: PropTypes.string,
-  tabIndex: PropTypes.oneOfType([PropTypes.number]),
+  tabIndex: PropTypes.number,
 };
 
 function isTrivialHref(href?: string) {

diff --git a/src/Button.tsx b/src/Button.tsx
@@ -9,7 +9,7 @@ interface UseButtonPropsOptions {
   type?: ButtonType;
   href?: string;
   disabled?: boolean;
-  target?: any;
+  target?: string;
   rel?: string;
   onClick?: React.EventHandler<React.MouseEvent | React.KeyboardEvent>;
   tabIndex?: number;

diff --git a/src/Nav.tsx b/src/Nav.tsx
@@ -30,8 +30,6 @@ const propTypes = {
   /** @private */
   onKeyDown: PropTypes.func,
   /** @private */
-  parentOnSelect: PropTypes.func,
-  /** @private */
   activeKey: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
 };
 
@@ -40,7 +38,6 @@ export interface NavProps
   activeKey?: EventKey;
   as?: React.ElementType;
   onSelect?: SelectCallback;
-  parentOnSelect?: SelectCallback;
 }
 
 const EVENT_KEY_ATTR = dataAttr('event-key');

diff --git a/src/NavItem.tsx b/src/NavItem.tsx
@@ -5,19 +5,23 @@ import useEventCallback from '@restart/hooks/useEventCallback';
 
 import NavContext from './NavContext';
 import SelectableContext, { makeEventKey } from './SelectableContext';
-import { EventKey, DynamicRefForwardingComponent } from './types';
+import {
+  EventKey,
+  DynamicRefForwardingComponent,
+  SelectCallback,
+} from './types';
 import Button from './Button';
 import { dataAttr } from './DataKey';
 
 export interface NavItemProps
   extends Omit<React.HTMLAttributes<HTMLElement>, 'onSelect'> {
   active?: boolean;
-  as: React.ElementType;
+  as?: React.ElementType;
   disabled?: boolean;
   eventKey?: EventKey;
   href?: string;
   tabIndex?: number;
-  onSelect?: (navKey: string, e: any) => void;
+  onSelect?: SelectCallback;
 }
 
 const propTypes = {
@@ -26,9 +30,8 @@ const propTypes = {
   role: PropTypes.string,
 
   href: PropTypes.string,
-  tabIndex: PropTypes.oneOfType([PropTypes.number, PropTypes.string]),
+  tabIndex: PropTypes.number,
   eventKey: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
-  onclick: PropTypes.func,
 
   as: PropTypes.any,
   onClick: PropTypes.func,