-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android : adding localbroadcastmanager support (#594 Fix) #596
Android : adding localbroadcastmanager support (#594 Fix) #596
Conversation
please merge this PR otherwise this library broken with 0.69+ version of react native |
@manuquentin please can you check this PR. Thank you! |
Thanks @ohheyitskartik ! |
Hi @manuquentin ! Thanks for your work, would it be possible to make a new release now that this PR has been merged please? 🙂 |
@manuquentin any update on when this can be released? |
Join the question |
@manuquentin, can you update the package on https://www.npmjs.com/package/react-native-callkeep?? |
This has been released months ago. |
Last release appears to be April 15 2022 version 4.3.3 and this PR was merged July 19 2022 so this still needs a release. |
@saghul the last release I see was on Apr 15, 2022 and this PR was on Jul 19, 2022. It is not released yet, right. Could you please check. |
Oh wait sorry, I thought this was a different repo 😅 Ping @sboily ? |
Hello, yes we can do it. @manuquentin please make a release if there is no objection. |
Hi the version |
Fix for issue #594
Google has split the v4 library into multiple packages :
Note: Prior to Support Library revision 24.2.0, there was a single v4 support library. That library was divided into multiple modules to improve efficiency. For backwards compatibility, if you list support-v4 in your Gradle script, your app will include all of the v4 modules. However, to reduce app size, we recommend that you just list the specific modules your app needs.
https://developer.android.com/reference/android/support/v4/content/LocalBroadcastManager
hence explicitly adding androidx.localbroadcastmanager:localbroadcastmanager:1.1.0 dependency