Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android : adding localbroadcastmanager support (#594 Fix) #596

Conversation

ohheyitskartik
Copy link

Fix for issue #594
Google has split the v4 library into multiple packages :

Note: Prior to Support Library revision 24.2.0, there was a single v4 support library. That library was divided into multiple modules to improve efficiency. For backwards compatibility, if you list support-v4 in your Gradle script, your app will include all of the v4 modules. However, to reduce app size, we recommend that you just list the specific modules your app needs.

https://developer.android.com/reference/android/support/v4/content/LocalBroadcastManager

hence explicitly adding androidx.localbroadcastmanager:localbroadcastmanager:1.1.0 dependency

@erennyuksell
Copy link

please merge this PR otherwise this library broken with 0.69+ version of react native

@sboily
Copy link
Member

sboily commented Jul 18, 2022

@manuquentin please can you check this PR. Thank you!

@sboily sboily requested a review from manuquentin July 18, 2022 19:53
@sboily sboily added android bug Something isn't working need review Need to review ticket labels Jul 18, 2022
@manuquentin
Copy link
Contributor

Thanks @ohheyitskartik !

@manuquentin manuquentin merged commit 4b1fa98 into react-native-webrtc:master Jul 19, 2022
@avencat
Copy link

avencat commented Aug 9, 2022

Hi @manuquentin ! Thanks for your work, would it be possible to make a new release now that this PR has been merged please? 🙂

@christopherklint97
Copy link

@manuquentin any update on when this can be released?

@TacticCoder
Copy link

Join the question

@pierguinzani
Copy link

@manuquentin, can you update the package on https://www.npmjs.com/package/react-native-callkeep??

@santhoshvai
Copy link

santhoshvai commented Jan 17, 2023

@saghul @sboily can you coordinate on making a new release please.

@saghul
Copy link
Member

saghul commented Jan 17, 2023

This has been released months ago.

@christopherklint97
Copy link

Last release appears to be April 15 2022 version 4.3.3 and this PR was merged July 19 2022 so this still needs a release.

@santhoshvai
Copy link

@saghul the last release I see was on Apr 15, 2022 and this PR was on Jul 19, 2022. It is not released yet, right. Could you please check.

@saghul
Copy link
Member

saghul commented Jan 17, 2023

Oh wait sorry, I thought this was a different repo 😅

Ping @sboily ?

@sboily
Copy link
Member

sboily commented Jan 18, 2023

Hello, yes we can do it. @manuquentin please make a release if there is no objection.

@manuquentin
Copy link
Contributor

manuquentin commented Jan 18, 2023

Hi the version 4.3.4 has been deployed, sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android bug Something isn't working need review Need to review ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants