[Android] Split setup into registerPhoneAccount and registerAndroidEvents #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@manuquentin Thanks for this PR. We were looking for something like this! It seems like this PR doesn't take the following into account:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reading #221, it seems really interesting to have separate method to register the phone account on Android.
I've splited the
setup()method on Android intoregisterPhoneAccount()andregisterAndroidEvents().We've the case when the user has disable the phone account, but calling
setup()always prompt the user to enable it...By using
registerPhoneAccount()instead ofsetup()we can now bind the events without prompting the user when the phone account is disabled.I don't have backported the
checkPhoneAccountEnabledmethod from #221 because it's already the job ofhasPhoneAccount.