Fix for RN spinner #416
Closed
Fix for RN spinner #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hello @billnbell would you mind cleaning up the git history a little so it's clear I'm not merging 24 commits but just 1 commit? Thank you! 👍 |
|
@billnbell btw I just invited you to the organization, when you accept the invitation you won't need to use forks and will be able to close issues and etc. Thank you for your contributions! :) |
|
Please delete this PR for the new one. |
|
New one is clean |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#411
This fixes the issue for me. It shows spinner on time. I think when Build.VERSION_CODES.N came it it made sense to use ==, but now there are a ton of newer versions.
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N && display == RNDatePickerDisplay.SPINNER) {