Skip to content

Commit

Permalink
Do not explicitely depend on androidx.swiperefreshlayout:swiperefresh…
Browse files Browse the repository at this point in the history
…layout (#37139)

Summary:
Pull Request resolved: facebook/react-native#37139

This dependency is unnecessary. React Native already exposes a `api` dependency on
`androidx.swiperefreshlayout:swiperefreshlayout` so every consumer will also get it.

This is just another line in the template we can effectively remove.

Changelog:
[Android] [Changed] - Do not explicitely depend on androidx.swiperefreshlayout:swiperefreshlayout

Reviewed By: cipolleschi

Differential Revision: D45390819

fbshipit-source-id: cce34c6a09100d36ee5eb003bb30323f64f0bb9c

Original-Commit: facebook/react-native@179d5ab
  • Loading branch information
cortinico authored and facebook-github-bot committed Apr 28, 2023
1 parent 809625a commit d8da060
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions template/template/android/app/build.gradle
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
/*
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/

apply plugin: "com.android.application"
apply plugin: "org.jetbrains.kotlin.android"
apply plugin: "com.facebook.react"
Expand Down Expand Up @@ -108,8 +115,6 @@ dependencies {
// The version of react-native is set by the React Native Gradle Plugin
implementation("com.facebook.react:react-android")

implementation("androidx.swiperefreshlayout:swiperefreshlayout:1.0.0")

debugImplementation("com.facebook.flipper:flipper:${FLIPPER_VERSION}")
debugImplementation("com.facebook.flipper:flipper-network-plugin:${FLIPPER_VERSION}") {
exclude group:'com.squareup.okhttp3', module:'okhttp'
Expand Down

0 comments on commit d8da060

Please sign in to comment.