Skip to content

Commit

Permalink
Bump Folly to 2023.08.07.00 (#39798)
Browse files Browse the repository at this point in the history
Summary:
This bumps folly, to absorb facebook/folly@45fffa6 which fixes warnings in XCode 15, and NDK 26 (treated as error bc we have better hygiene there). We then bump a little bit further to get past a new warning added, then fixed later.

Need to manually set `FOLLY_HAVE_GETTIME` on Apple because of the silliness described in facebook/folly#1470 (comment)

There is not a combination of Folly, and Android libc++, that has fixes for warnings, but doesn't require the new libc++ in NDK 26. It is expected then that this commit will fail the build, but the next should succeed, and the two must be landed at the same time.

Changelog: [Internal]

Pull Request resolved: facebook/react-native#39798

Reviewed By: fkgozali

Differential Revision: D49897681

Pulled By: NickGerleman

fbshipit-source-id: 52b97ed5b302abf9e27f38dc655207827852dcc3

Original-Commit: facebook/react-native@aefefdb
  • Loading branch information
NickGerleman authored and facebook-github-bot committed Oct 5, 2023
1 parent 3d0c497 commit 714dab9
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions template/template/ios/HelloWorld.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -578,6 +578,7 @@
"-DFOLLY_MOBILE=1",
"-DFOLLY_USE_LIBCPP=1",
"-DFOLLY_CFG_NO_COROUTINES=1",
"-DFOLLY_HAVE_CLOCK_GETTIME=1",
);
SDKROOT = iphoneos;
};
Expand Down Expand Up @@ -642,6 +643,7 @@
"-DFOLLY_MOBILE=1",
"-DFOLLY_USE_LIBCPP=1",
"-DFOLLY_CFG_NO_COROUTINES=1",
"-DFOLLY_HAVE_CLOCK_GETTIME=1",
);
SDKROOT = iphoneos;
VALIDATE_PRODUCT = YES;
Expand Down

0 comments on commit 714dab9

Please sign in to comment.