Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

0.54.x Discussion #10

Closed
grabbou opened this issue Mar 21, 2018 · 15 comments
Closed

0.54.x Discussion #10

grabbou opened this issue Mar 21, 2018 · 15 comments
Labels
backport request Cherry picking a change into an existing release stable Stable version

Comments

@grabbou
Copy link
Member

grabbou commented Mar 21, 2018

Please report any major issues and commits to cherry-pick in this thread for discussion.
@grabbou grabbou added the stable Stable version label Mar 21, 2018
@grabbou grabbou changed the title 0.54-stable: Requests and reports 0.54.x: Requests and reports Mar 21, 2018
@grabbou grabbou changed the title 0.54.x: Requests and reports 0.54.x: Discussion Mar 21, 2018
This was referenced Mar 21, 2018
Closed
Closed
@eliperkins
Copy link

facebook/react-native@a534672 to fix the regression outlined in facebook/react-native#18258

@grabbou
Copy link
Member Author

grabbou commented Mar 21, 2018

Thank you! This will get released as soon as we figure out the problem with context as reported here: facebook/react-native#18351. Unfortunately, we have a choice of either downgrading React version or cherry-picking a lot of changes to the renderer that were made over time to master. I've passed this subject to more qualified core team members and waiting for their feedback today. Once this gets sorted, we will proceed with the next release.

CC: @hramos

@turnrye turnrye added the backport request Cherry picking a change into an existing release label Mar 22, 2018
@turnrye turnrye changed the title 0.54.x: Discussion 0.54.x Discussion Mar 22, 2018
@asowayan
Copy link

@grabbou This commit fixes a regression that broke our app. It would be great to be in a minor release of RN 0.54.4, and definitely should be in the upcoming 0.55 release.

facebook/react-native@15fa225

@grabbou
Copy link
Member Author

grabbou commented Mar 26, 2018 via email

@grabbou
Copy link
Member Author

grabbou commented Mar 26, 2018 via email

@asowayan
Copy link

@grabbou Thanks for your quick response. Yes, we can wait for 0.55 (we've implemented a work around). I do notice though that 0.54.3 has not been published to NPM yet:

https://www.npmjs.com/package/react-native?activeTab=versions

@grabbou
Copy link
Member Author

grabbou commented Mar 26, 2018 via email

@grabbou
Copy link
Member Author

grabbou commented Mar 28, 2018

Cherry-pick as requested facebook/react-native#18223 (comment)

@grabbou grabbou mentioned this issue Mar 28, 2018
Closed
grabbou referenced this issue in facebook/react-native Mar 28, 2018
@esamelson @facebook-github-bot
fix ReadableNativeMap.toHashMap() for nested maps and arrays
15fa225 
Summary:
<!--
  Required: Write your motivation here.
  If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
-->

Commit 7891805 broke the previous behavior of `ReadableNativeMap.toHashMap()` for nested maps and arrays. Previously, all nested `ReadableNativeMap`s and `ReadableNativeArray`s were recursively converted to `HashMap`s and `ArrayList`s, but this is lost when only `getLocalMap()` is returned.

<!--
  Required: Write your test plan here. If you changed any code, please provide us with
  clear instructions on how you verified your changes work. Bonus points for screenshots and videos!
-->

Call `ReadableNativeMap.toHashMap()` on a map with values of type `ReadableNativeMap` and `ReadableNativeArray`. Verify the returned hash map has these converted to `HashMap` and `ArrayList`, respectively.

<!--
  Does this PR require a documentation change?
  Create a PR at https://github.com/facebook/react-native-website and add a link to it here.
-->

<!--
  Required.
  Help reviewers and the release process by writing your own release notes. See below for an example.
-->

[ANDROID] [BUGFIX] [ReadableNativeMap] - Fix toHashMap() for nested maps and arrays

<!--
  **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**

    CATEGORY
  [----------]      TYPE
  [ CLI      ] [-------------]    LOCATION
  [ DOCS     ] [ BREAKING    ] [-------------]
  [ GENERAL  ] [ BUGFIX      ] [ {Component} ]
  [ INTERNAL ] [ ENHANCEMENT ] [ {Filename}  ]
  [ IOS      ] [ FEATURE     ] [ {Directory} ]   |-----------|
  [ ANDROID  ] [ MINOR       ] [ {Framework} ] - | {Message} |
  [----------] [-------------] [-------------]   |-----------|

 EXAMPLES:

 [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
 [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
 [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
 [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
 [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
 [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
-->
Closes #18455

Reviewed By: kathryngray

Differential Revision: D7347344

Pulled By: mdvacca

fbshipit-source-id: af2bca9dec6c0cb8a7da099b6757434fcc3ac785
@grabbou
Copy link
Member Author

grabbou commented Mar 28, 2018

@asowayan I will also cherry pick your request into 0.54.4 today because the issue has been introduced today and I am releasing another version anyway.

@Gyran
Copy link

Gyran commented Mar 29, 2018

Would it be possible to pick facebook/react-native@b02b167 to fix facebook/react-native#18179?

@guysegal
Copy link

@grabbou when do you plan to publish 0.54.4?

@grabbou
Copy link
Member Author

grabbou commented Mar 29, 2018 via email

@Gyran
Copy link

Gyran commented Apr 3, 2018 •
edited
Loading

unfortunately not.
For major version 0, minor bumps are considered breaking.

^0.28.0 => >=0.28.0 <0.29.0.
^1.28.0 => >=1.28.0 <2.0.0.

https://jubianchi.github.io/semver-check/
https://docs.npmjs.com/misc/semver#caret-ranges-123-025-004

@grabbou grabbou closed this as completed Apr 3, 2018
@grabbou
Copy link
Member Author

grabbou commented Apr 3, 2018

Oh, I see - the 0.54 branch is on 0.28.x channel. I am going to put this on hold for now and see what Metro team says in that regards (whether it's a safe bump or not).

Note that on 0.55 branch, this problem should not persist anyway.

@SASoto

This comment has been minimized.

Sign in to view
@react-native-community react-native-community locked as resolved and limited conversation to collaborators Jul 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
backport request Cherry picking a change into an existing release stable Stable version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@Gyran @turnrye @eliperkins @grabbou @asowayan @guysegal @SASoto and others