Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

Commit

Permalink
Updated for more context and yaml metadata block
Browse files Browse the repository at this point in the history
  • Loading branch information
turnrye committed Jul 10, 2018
1 parent 7907287 commit a92bf1f
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 25 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Stay up-to-date with the release activities of [React Native](https://github.com

## Request for Comments

For details on the RFC process, please visit the [Request for Comment](/rfcs/README.md) README.
For details on the RFC process, please visit the [Request for Comment](/rfcs/README.md) README. Today, we don't expect for every substantial change to go through this process; however, we hope that this brings more awareness to the community.

## Release Status Issues

Expand Down
31 changes: 17 additions & 14 deletions rfcs/0000-template.md
Original file line number Diff line number Diff line change
@@ -1,26 +1,30 @@
- Start Date: (fill me in with today's date, YYYY-MM-DD)
- RFC PR: (leave this empty)
- React Issue: (leave this empty)
---
title: Title goes here
author:
- Jane Doe
date: today
---
# RFC0000: Title goes here

# Summary
## Summary

Brief explanation of the change.

# Basic example
## Basic example

If the proposal involves a new or changed API, include a basic code example. Omit this section if it's not applicable.

# Motivation
## Motivation

Why are we doing this? What use cases does it support? What is the expected outcome?

Please focus on explaining the motivation so that if this RFC is not accepted, the motivation could be used to develop alternative solutions. In other words, enumerate the constraints you are trying to solve without coupling them too closely to the solution you have in mind.

# Detailed design
## Detailed design

This is the bulk of the RFC. Explain the design in enough detail for somebody familiar with React Native to understand, and for somebody familiar with the implementation to implement. This should get into specifics and corner-cases, and include examples of how the feature is used. Any new terminology should be defined here.

# Drawbacks
## Drawbacks

Why should we *not* do this? Please consider:

Expand All @@ -32,23 +36,22 @@ Why should we *not* do this? Please consider:

There are tradeoffs to choosing any path. Attempt to identify them here.

# Alternatives
## Alternatives

What other designs have been considered? Why did you select your approach?

# Adoption strategy
## Adoption strategy

If we implement this proposal, how will existing React Native developers adopt it? Is this a breaking change? Can we write a codemod? Should we coordinate with other projects or libraries?

# How we teach this
## How we teach this

What names and terminology work best for these concepts and why? How is this idea best presented? As a continuation of existing React patterns?

Would the acceptance of this proposal mean the React Native documentation must be re-organized or altered? Does it change how React Native is taught to new developers at any level?

How should this feature be taught to existing React Native developers?

# Unresolved questions
## Unresolved questions

Optional, but suggested for first drafts. What parts of the design are still
TBD?
Optional, but suggested for first drafts. What parts of the design are still TBD?
20 changes: 10 additions & 10 deletions rfcs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,16 @@ Some changes do not require an RFC:

In short, to get a major feature added to React Native, one usually first gets the RFC merged into the RFC repo as a markdown file. At that point the RFC is "active" and may be implemented with the goal of eventual inclusion into React Native.

* Fork the RFC repo http://github.com/react-native-community/react-native-releases
* Copy `rfcs/0000-template.md` to `rfcs/0000-my-feature.md` (where 'my-feature' is descriptive. don't assign an RFC number yet).
* Fill in the RFC. Put care into the details: **RFCs that do not present convincing motivation, demonstrate understanding of the impact of the design, or are disingenuous about the drawbacks or alternatives tend to be poorly-received**.
* Submit a pull request with the label "rfc". As a pull request the RFC will receive design feedback from the larger community, and the author should be prepared to revise it in response.
* Build consensus and integrate feedback. RFCs that have broad support are much more likely to make progress than those that don't receive any comments.
* Eventually, the team will decide whether the RFC is a candidate for inclusion in React Native.
* RFCs that are candidates for inclusion in React Native will enter a "final comment period" lasting 7 days. The beginning of this period will be signaled with a comment and tag on the RFC's pull request.
* An RFC can be modified based upon feedback from the team and community. Significant modifications may trigger a new final comment period.
* An RFC may be rejected by the team after public discussion has settled and comments have been made summarizing the rationale for rejection. A member of the team should then close the RFC's associated pull request.
* An RFC may be accepted at the close of its final comment period. A team member will merge the RFC's associated pull request, at which point the RFC will become 'active'.
- Fork the RFC repo [react-native-community/react-native-releases](http://github.com/react-native-community/react-native-releases)
- Copy `rfcs/0000-template.md` to `rfcs/0000-my-feature.md` (where 'my-feature' is descriptive. don't assign an RFC number yet).
- Fill in the RFC. Put care into the details: **RFCs that do not present convincing motivation, demonstrate understanding of the impact of the design, or are disingenuous about the drawbacks or alternatives tend to be poorly-received**.
- Submit a pull request with the label "rfc". As a pull request the RFC will receive design feedback from the larger community, and the author should be prepared to revise it in response.
- Build consensus and integrate feedback. RFCs that have broad support are much more likely to make progress than those that don't receive any comments.
- Eventually, the team will decide whether the RFC is a candidate for inclusion in React Native.
- RFCs that are candidates for inclusion in React Native will enter a "final comment period" lasting 7 days. The beginning of this period will be signaled with a comment and tag on the RFC's pull request.
- An RFC can be modified based upon feedback from the team and community. Significant modifications may trigger a new final comment period.
- An RFC may be rejected by the team after public discussion has settled and comments have been made summarizing the rationale for rejection. A member of the team should then close the RFC's associated pull request.
- An RFC may be accepted at the close of its final comment period. A team member will merge the RFC's associated pull request, at which point the RFC will become 'active'.

## The RFC life-cycle

Expand Down

0 comments on commit a92bf1f

Please sign in to comment.