0.57.5 Discussion

[kelset]

Conversation on this thread are limited to 0.57.5 release's major issues and backport (cherry-pick) requests from commits that are already on master - so that we can then produce a 0.57.6 release in the near future.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.57.5 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.57-stable branch yourself, in order to ensure that the process proceeds smoothly.

[dulmandakh]

• fix http timeout on Android - facebook/react-native@a508134
• web socket handle remote close on Android - facebook/react-native@2e465bc

[ChrisEdson]

• Fix for FlatList scrolling in Android 9 - facebook/react-native@b971c5b

[dulmandakh]

• apply Image.resizeMode to defaultSource - facebook/react-native@673ef39

[flybayer]

• Fix no bundle URL when using SKIP_BUNDLING with iOS device - facebook/react-native@9c1ea45

[matpaul]

• Add iOS 12 textContentType options - facebook/react-native@644fc57

[kelset]

Thanks everyone for the suggestions, I'm starting to consider creating the next release.

Aside from those, I'll probably reverse facebook/react-native@ce09d6e given that it causes crashes in production.

[radeno]

My two cents:

• Fix React Native AsyncMode and DevTools. facebook/react-native@aacb06c
• Fix compatibility issue for android 16 device. facebook/react-native@5939d07
• Remove unused loads from xplat. facebook/react-native@9b781bd
• Fix crash when releasing RN views facebook/react-native@83405ff
• CxxReact: Silence 'unused lambda capture' warnings in open-source facebook/react-native@0c05409
• Remove useless additionnal blur call facebook/react-native@27cfba2
• Resolve two gradle deprecation warnings facebook/react-native@4514041

@kelset about crashing of <Image> component we don't have any issues. But we we use only for local images, for remote <FastImage>
What about Jest/Flow/Metro, there are still issues what was discussed in previous version topic?

[terrysahaidak]

Hi @kelset, inverted flat list fix on android 9 should be landed in this release because it's really critical, I think. it breaks every app that has a chat ability. but new 58 release because of fabric and etc may contain some new bugs (it's ok).

[watadarkstar]

Not sure if we can still cherry pick at this point but I'd really like as mentioned by @terrysahaidak but with a link to the commit:

• Fix inverted ScrollViews on Android P facebook/react-native@b971c5b

[radeno]

@watadarkstar already requested #64 (comment) make thumb up :)

[watadarkstar]

Done 👍 didn't see that @radeno

[estevaolucas]

• Fix inability to remove 'Disabled' state from AccessibilityStates facebook/react-native@5eaa2d2. (it went straight to 0.58.0-rc.0, but would be important to also have it on 0.57)

[kelset]

Thanks everyone for the requests, I'll try now to apply them and we'll see how it goes...

[kelset]

Update: I've managed to cherry-pick and test locally ✅ this list of commits:

• Generate ip.txt before SKIP_BUNDLING check
• Fix inability to remove 'Disabled' state from AccessibilityStates
• Add iOS 12 textContentType options
• Improving Modal visible prop check to handle undefined and null
• Fix IllegalArgumentException when dismissing ReactModalHostView
• NetInfo: try to solve crash with releasing _firstTimeReachability
• Android: Close websocket properly when remote server initiates close
• Fix regression in StyleSheet.setStyleAttributePreprocessor
• Fix crash when releasing RN views
• Fixed HTTP connection timeout on Android
• Workaround a wrong fling direction for inverted ScrollViews on Android P
• Fix React Native AsyncMode and DevTools
• resizeMode applies to Image.defaultSource
• CxxReact: Silence 'unused lambda capture' warnings in open-source
• Remove useless additionnal blur call
• iOS: Support inline view truncation

I've also reverted the commit about iOS Image optimization, and merged a PR directly to the branch that fixes an issue with HMR (facebook/react-native#22412).

I haven't cherry picked because they were causing conflicts:

• Remove unused loads from xplat.
• Fix compatibility issue for android 16 device
• Resolve two gradle deprecation warnings

I will not cherry pick updates for Flow/Metro/Jest because we agreed to try and keep as upgrade-free as possible the patch releases. And jest 24 is still in alpha.

Once the CI is green I'll proceed to create the version.

[kelset]

0.57.6 is out, all my tests are ✅ so I'll proceed with closing this and opening the new one. Changelog will land soon.