Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

0.57.5 Discussion #64

Closed
kelset opened this issue Nov 13, 2018 · 15 comments
Closed

0.57.5 Discussion #64

kelset opened this issue Nov 13, 2018 · 15 comments
Labels
backport request Cherry picking a change into an existing release stable Stable version

Comments

@kelset
Copy link
Member

kelset commented Nov 13, 2018

Conversation on this thread are limited to 0.57.5 release's major issues and backport (cherry-pick) requests from commits that are already on master - so that we can then produce a 0.57.6 release in the near future.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.57.5 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.57-stable branch yourself, in order to ensure that the process proceeds smoothly.

@kelset kelset added stable Stable version backport request Cherry picking a change into an existing release labels Nov 13, 2018
@dulmandakh
Copy link
Contributor

@ChrisEdson
Copy link

ChrisEdson commented Nov 15, 2018

@dulmandakh
Copy link
Contributor

@flybayer
Copy link

@matpaul
Copy link

matpaul commented Nov 17, 2018

@kelset
Copy link
Member Author

kelset commented Nov 22, 2018

Thanks everyone for the suggestions, I'm starting to consider creating the next release.

Aside from those, I'll probably reverse facebook/react-native@ce09d6e given that it causes crashes in production.

@radeno
Copy link

radeno commented Nov 23, 2018

My two cents:

@kelset about crashing of <Image> component we don't have any issues. But we we use only for local images, for remote <FastImage>
What about Jest/Flow/Metro, there are still issues what was discussed in previous version topic?

@terrysahaidak
Copy link

Hi @kelset, inverted flat list fix on android 9 should be landed in this release because it's really critical, I think. it breaks every app that has a chat ability. but new 58 release because of fabric and etc may contain some new bugs (it's ok).

@watadarkstar
Copy link

Not sure if we can still cherry pick at this point but I'd really like as mentioned by @terrysahaidak but with a link to the commit:

@radeno
Copy link

radeno commented Nov 26, 2018

@watadarkstar already requested #64 (comment) make thumb up :)

@watadarkstar
Copy link

Done 👍 didn't see that @radeno

@estevaolucas
Copy link

  • Fix inability to remove 'Disabled' state from AccessibilityStates facebook/react-native@5eaa2d2. (it went straight to 0.58.0-rc.0, but would be important to also have it on 0.57)

@kelset
Copy link
Member Author

kelset commented Nov 26, 2018

Thanks everyone for the requests, I'll try now to apply them and we'll see how it goes...

@kelset
Copy link
Member Author

kelset commented Nov 26, 2018

@kelset
Copy link
Member Author

kelset commented Nov 26, 2018

0.57.6 is out, all my tests are ✅ so I'll proceed with closing this and opening the new one. Changelog will land soon.

@kelset kelset closed this as completed Nov 26, 2018
@react-native-community react-native-community locked as resolved and limited conversation to collaborators Nov 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport request Cherry picking a change into an existing release stable Stable version
Projects
None yet
Development

No branches or pull requests

9 participants