Fix crash in nativeInjectHMRUpdate #22412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
kelset
reviewed
Nov 26, 2018
| @@ -113,7 +113,7 @@ static JSValueRef nativeInjectHMRUpdate( | |||
| const JSValueRef arguments[], | |||
| JSValueRef* exception) { | |||
| String execJSString = Value(ctx, arguments[0]).toString(); | |||
| String jsURL = Value(ctx, arguments[1]).toString(); | |||
| String jsURL = argumentCount > 1 ? Value(ctx, arguments[1]).toString() : String(); | |||
There was a problem hiding this comment.
would you mind just adding a comment for our future selves, something like
temporary workaround for 0.57 and Metro 48
so that if I encounter any issue in future releases/cherry-picks I can quickly remember what this was about?
|
Thanks for being so quick! Super appreciated :) If you can add the comment it would be perfect, in the meantime I'll have it double-checked & tested in my release :) (btw, if you are on twitter, can you shoot me a DM over there?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix crash in nativeInjectHMRUpdate if it is called with only one argument from JS
Fixes #22116
For more deep explanation, see comments thread from here: #22116 (comment)
Environment:
This fix dedicated for
0.57-stablebranch, because crashed code was part of old JSC executor, that was replaced in master with new JSI code.Test Plan:
Ensure that application no more crash when enable HMR from dev menu.
Changelog:
[iOS] [Fixed] - Fix application crash when HMR enabled