-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish the "new app screen" #122
Comments
I've not used the new app for a while so this might not be relevant, but as a proposal I'd be very interested to see some default bundled assets for Android and iOS - perhaps fonts, maybe an image or two (not just SVGs) - at various resolutions. When I started RN way back I remember this being a point of confusion for me. Being able to get moving quicker on these subjects based off a template / best practice (rather then Stack Overflow'ing it all!) would be welcome I suspect. |
@JofBigHealth That's a great point, and I agree this is painful. We are considering rewriting the website and all documentation and hopefully we can improve this. I would prefer us not to include any assets by default that are not necessary (we can download them in the new app experience for example, or embed it in the JS component) so we do not increase people's app size unnecessarily. |
I think a nice RN icon at various sizes (and including the Android notifications icons and all that various other stuff I didn't learn until the app was in production!) would be super helpful though. On the subject of documentation I think a lot of new users would welcome expanding the content to include some of these more "native" and platform specific elements of configuration. I realise a case could be made that "this isn't RN so shouldn't be in the docs" but I think it'll really help newcomers get a better impression of RN. I watch a number of threads - especially related to Android - where these "native" areas of configuration frustrate new users and give the impression of RN being excessively hard to use. For instance the challenges related to network security settings for RN debugging can turn off developers inexperienced with native dev. |
How about a multilanguage translation of |
@JofBigHealth I absolutely agree but this is not the right place for that discussion. Let's have that on the website repo. |
Depending on the scope and size of the screen, it'd be nice to cycle this with a very simple animation. Or, display the English version in the center with a "cloud" of other languages around it. |
simple calculation form that contain buttons and inputs |
Perhaps some sort of light intro to react native via slidable cards? Whenever you swipe to next card, change background colour with animation or something of sorts. Could give good example for people who are starting out on state / animation / gestures etc... as well It would be a tad much code wise though, but if placed in some sort of "welcome" folder that is easily deletable, won't be too crazy? |
A LottieFiles animation can be attractive for beginners. Here's a lottie React logo https://lottiefiles.com/296-react-logo |
It would be great to have a new fancy intro screen, but please don't make it too bloated... 😊 |
This screen should be simple and useful. For showing off stuff, we can use |
(disclaimer: I only had 30m so these designs are for discussion and not too polished ) I think there's two angles this could go, depending on the goals:
( sketch file ) |
How about add text where you telling about the minuses eg:
|
@orta omg I love both of them and will have to put on my thinking cap to figure out which one I prefer. We can definitely put this up to a vote. @everyone thanks to your great ideas so far! I think in general "mockups win arguments!" so if you can come up with a mockup for your design idea, then at the end we can put all of them to a vote :) @retyui thanks for your comment. I think you are making a great point and we could have a section like "How do I…" including things like "add navigation" that links to the docs comparing popular navigation solutions. |
@adamshurson go for it! I think having something to play with is much better than just a design (which is already better than just ideas). It will definitely help us make a decision and explore our options. Just keep in mind that we are currently in the exploratory and discussion stage, so this may be one of those times where you are building an MVP to show off and it may take a couple of iterations until we get something that we are happy with that can be merged! I just wanna make sure you are aware of that before you start :) |
@cpojer of course! |
Awesome design @orta I love them both. I like the layout of the 2nd one, but the light version looks more inviting to me. Possible light version of the 2nd one? Figma: https://www.figma.com/file/LiPBm4fCeURQBt2nGTkHGqnD/rn-init?node-id=0%3A1 |
damn @adamshurson, you beat me to it. If you don't want to do it anymore, let me know 😛 |
A nice little animation where the welcome text bounces in. |
Thanks folks - good idea @retyui on making it easy to get to docs, I've added something like that @iRoachie nice touch, in my copy here I want it to scroll, so I moved the logo up into the header. I think the white mode kinda offers something a bit more hybrid? I dunno how it would feel seeing this as an android dev ( though it would use system fonts, not the apple system fonts here ) Those buttons would open your Safari/Chrome in your computer and take you to the corresponding pages on the react-native docs. I tried to somewhat give a from-scratch narrative left to right there too. The code that gets shipped here could well be the first RN code someone sees, so I'd be wary about adding things like animations and anything too complex which we can't safely hide away. |
This is so good @orta. I couldn't have dreamt it better. |
I think the important things of
|
damn this looks amazing, I hope this is soon merged with 0.60.x, this will be like a new beginning for RN 😃 |
@orta links like |
They can't be the same color because they have different actions (one you can click on, the other you can't) but I agree on darkening them somehow 👍 I'm still not sold on the buttons as a metaphor, I want something like this but it doesn't feel like it's what you build in a native app to me yet |
OK, given it another shot. It's rare to see buttons mixed like that in a mobile context, so I looked at how it's typically handled and this second one feels a lot closer to the sort of designs we've made at Artsy in the past for these problems. So I've tightened up the design of the top and explored a more mobile approach to the learn more section |
@orta Perhaps that separation between Looks much cleaner now 👌 |
Lottie comes with native dependencies. We cannot take such a dependency on within React Native itself for technical reasons. I suggest using an image instead and making it look like in @orta’s mockup from above. |
@cpojer Thoughts on these? I forked @glauberfc 's code and quickly made this, also I removed the Lottie integration. |
How does it look on android? |
@iRoachie looks identical, tho font appears a little big on small devices |
Nice work and nice group effort! Do you wanna start taking this to RN itself and send a PR so we can give comments on the code and iterate on it from there? |
@cpojer ok I'll send a pull request asap |
Good job, @karanpratapsingh! |
@glauberfc No mate, you did all the heavy lifting. It's a team effort 🎉 |
@cpojer you should see a new pull request by the name of |
Edit the PR to mention this Issue number so it shows here |
ahhhhh lookes like my builds are working fine but prettier formatting is failing 🤣 |
Thanks everyone for the awesome discussion here. I'll close this issue and we can continue to iterate and polish the new screen in the PR on react-native :) |
Summary: Continuation of #24687 > Issue: [Polish the "new app screen"](react-native-community/discussions-and-proposals#122) > This is the pull request for the new intro screen proposal in react native as directed by cpojer This PR was created because the previous one could not be pushed to for some reason. I cleaned up a few small things and added the component as an example to RNTester so we can keep iterating. My plan is to land this, and then polish it and make it the default in a follow-up. [General][Added] - New Intro screen, Icons Removed Lottie Integration 100% React Native 💥 Pull Request resolved: #24737 Differential Revision: D15259092 Pulled By: cpojer fbshipit-source-id: bc141fb1425cf354f29deffd907c37f83fd92c75
great to see this merged 🎉 |
Summary: This replaces the "new app screen" in the template with the new design from react-native-community/discussions-and-proposals#122 This uses components that are shipped as part of the `react-native` module, but not necessarily as proper components exported by the main `react-native` module. To use these, we use absolute imports to those components. Related to #24760 [General] [Changed] - Updated new app template design 💖 Pull Request resolved: #24805 Differential Revision: D15334459 Pulled By: cpojer fbshipit-source-id: d0b67d08f936eeabd9e93d4e0ff78302b4d6429f
Thanks everyone for your awesome work on this new app experience! It is now merged and will be in the next release of React Native. @rickhanlonii and I made a brief video to show off the new screen: https://www.youtube.com/watch?v=ImlAqMZxveg&feature=youtu.be |
@cpojer Great Video, glad to be a part of this community 🎉 |
@cpojer That's awesome! |
Bump... new RN dev here and I'm loving it. Awesome framework and community. (P.S. Can you consider 8 months as new?) :) |
Loved the video! 😍 off-topic: when is the next version slated to be released? Is there a dedicated thread where we can subscribe to keep up with it? |
@xgenem glad to have you in the community, we’re all new here, I am also new 😃 |
@Monte9 I was wondering the same thing 🧐 |
@cpojer how do I join as a contributor?? Sorry I’m new here,New app screen was my first pull request in React Native 😀 |
@karanpratapsingh there is a And here is the discussion thread for 0.60 release: react-native-community/releases#116 |
Introduction
React Native has had the same new app screen since it was initially created. The screen is simple and welcomes people to React Native and promotes hot reloading. Let's spend some time thinking how we could make the new app experience more awesome by redesigning this screen, mainly targeted at newcomers to React Native! Ideally it will look simple and elegant but richer than now. The main goal is for people who are just starting out and for experienced people to be delighted.
Possible Ideas:
<marquee>
style news banner. Just kidding, or am I?).In terms of implementation I would imagine a simple component like
<AppTemplate />
that will be required throughreact-native/Libraries/AppTemplate
and is not exported throughreact-native
to ensure it does not bloat real apps. A simple invocation like also makes it easy for people to remove.Recently the community drove a redesign of the "RedBox" screen: #42. I'm curious to hear your ideas and would love to see some mockups of what people can come up with!
The current screen, for reference:
The text was updated successfully, but these errors were encountered: