Prevent crash in findMatchingSimulator #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grabbou
reviewed
Jan 9, 2019
| @@ -31,7 +31,7 @@ function findMatchingSimulator(simulators, simulatorString) { | |||
| const parsedSimulatorName = simulatorString | |||
| ? simulatorString.match(/(.*)? (?:\((.*)?\))?/) | |||
| : []; | |||
| if (parsedSimulatorName[2] !== undefined) { | |||
| if (parsedSimulatorName && parsedSimulatorName[2] !== undefined) { | |||
There was a problem hiding this comment.
This is interesting.
On line 31, we make sure it's either a matched value or an array - it shouldn't be "undefined" at all.
Could you provide more details when this would be null, or causing a crash?
There was a problem hiding this comment.
Ah, it confused me:
simulatorString
? simulatorString.match(/(.*)? (?:\((.*)?\))?/)
: [];
Thought we check on simulator.match instead xd
thymikee
approved these changes
Jan 11, 2019
| @@ -31,7 +31,7 @@ function findMatchingSimulator(simulators, simulatorString) { | |||
| const parsedSimulatorName = simulatorString | |||
| ? simulatorString.match(/(.*)? (?:\((.*)?\))?/) | |||
| : []; | |||
| if (parsedSimulatorName[2] !== undefined) { | |||
| if (parsedSimulatorName && parsedSimulatorName[2] !== undefined) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findMatchingSimulatorcould crash if the simulator's name is custom (renamed in Xcode) for ex:iPhone6v11.After this fix it doesn't crash and the correct custom named simulator is chosen.